[EventHubs] add fixed backoff retry mode #21884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swathipil
requested review from
annatisch,
rakshith91 and
yunhaoling
as code owners
ghost
added
the
swathipil
commented
Nov 24, 2021
swathipil
commented
Nov 24, 2021
swathipil
commented
Nov 24, 2021
|
API changes have been detected in |
|
API changes have been detected in API changes - api_version: str,
+ api_version: str = ...,
- secondary_hostname: str,
+ secondary_hostname: str = ...,
- api_version: str,
+ api_version: str = ...,
- secondary_hostname: str,
+ secondary_hostname: str = ..., |
|
API changes have been detected in API changes - api_version: str,
- secondary_hostname: str,
+ api_version: str = ...,
+ secondary_hostname: str = ...,
- api_version: str,
- secondary_hostname: str,
+ api_version: str = ...,
+ secondary_hostname: str = ..., |
swathipil
commented
Nov 29, 2021
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API changes have been detected in |
yunhaoling
reviewed
Jan 3, 2022
yunhaoling
reviewed
Jan 3, 2022
yunhaoling
reviewed
Jan 3, 2022
yunhaoling
reviewed
Jan 3, 2022
yunhaoling
reviewed
Jan 3, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_consumer_client_async.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jan 3, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_consumer_client_async.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jan 3, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jan 3, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jan 3, 2022
| @@ -33,5 +34,6 @@ | |||
| "LoadBalancingStrategy", | |||
| "PartitionContext", | |||
| "parse_connection_string", | |||
| "EventHubConnectionStringProperties" | |||
| "EventHubConnectionStringProperties", | |||
| "RetryMode" | |||
There was a problem hiding this comment.
There're API changes, remember to get @annatisch to take a look at the API view before CC day :)
yunhaoling
reviewed
Jan 3, 2022
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
I'm approving this PR, but I would recommend letting @annatisch review the API changes first before merging it to avoid rolling back.
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
* sync retry mode impl * async impl * add test * pylint * lint * adams comments * lint * adams comments * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #8670