Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] Fix test assert for changing description value #22324

Merged
merged 3 commits into from
Jan 5, 2022
Merged

[formrecognizer] Fix test assert for changing description value #22324

merged 3 commits into from
Jan 5, 2022

Conversation

catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Jan 4, 2022 •
edited
Loading

Description

Operations may or may not have a description, this PR fixes the check for those test assertions.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@catalinaperalta
Copy link
Member Author

/azp run python - formrecognizer - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@catalinaperalta catalinaperalta marked this pull request as ready for review January 4, 2022 22:51
@catalinaperalta
Copy link
Member Author

The ci pipeline passed, running the test pipeline just to see if the issues with the list operations tests are resolved. There may still be some flakiness for other tests.

@catalinaperalta
Copy link
Member Author

/azp run python - formrecognizer - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

catalinaperalta
catalinaperalta commented Jan 5, 2022
View reviewed changes
scripts/devops_tasks/test_run_samples.py
Comment on lines +133 to +134
"sample_copy_model.py",
"sample_copy_model_async.py",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking issue: #22185

@catalinaperalta catalinaperalta merged commit 1261d34 into Azure:main Jan 5, 2022
@catalinaperalta catalinaperalta deleted the fixDescriptionAssert branch January 5, 2022 16:27
zihzhan-msft pushed a commit that referenced this pull request Jan 11, 2022
@huachuandeng @msyyc
@swathipil @catalinaperalta @BaherAbdullah @kristapratico @xiangyan99 @azure-sdk @benbp @mccoyp @azclibot @BigCat20196 @hildurhodd @mikeharder @sima-zhu @AikoBB @yunhaoling @scbedd @giakas
merge main branch (#22421)
f7d47ab 
* [Release issue status] Reduce max papallel (#22334)

* update assignee

* Update release_issue_status.yml

* [ServiceBus] fixed retry backoff (#22317)

* inital fixed retry commit

* changelog + version

* pylint

* [formrecognizer] Fix test assert for changing description value (#22324)

* fix assert for changing description value

* fix advanced samples file reference

* skip copy model samples

* Update README.md (#22259)

* Update README.md

updated Read me

* Update sdk/textanalytics/azure-ai-textanalytics/samples/README.md

Co-authored-by: Krista Pratico <krpratic@microsoft.com>

Co-authored-by: Krista Pratico <krpratic@microsoft.com>

* enable identity for py27 (#22341)

* enable identity for py27

* update

* drop py27 for ditital twins (#22343)

* [EventHub] drop python 2.7/3.6 (#22319)

* drop 2.7/3.6

* checkpointstoreblobs

* bump versions

* [SchemaRegistry] drop 2.7/36 (#22318)

* drop 2.7/36

* version

* drop 2.7/3.6

* Sync eng/common directory with azure-sdk-tools for PR 2484 (#22346)

* Add weekly pipeline generation to prepare-pipelines template

* Add succeeded condition to pipeline generation pipelines

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* [Key Vault] Skip tests failing with SAS issues (#22351)

* [AutoRelease] t2-consumption-2022-01-06-98359 (#22360)

* CodeGen from PR 17013 in Azure/azure-rest-api-specs
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01 (#17013)

* fixing s360 for these

* fixing styling issue

* Adding 204 to examples

* Fixing the model val for reservation by adding proper guid

Co-authored-by: Mita Garg <v-migarg@microsoft.com>

* version,CHANGELOG

* test

* update dev_requirements.txt

* update tests

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Mita Garg <v-migarg@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: BigCat20196 <1095260342@qq.com>

* [AutoRelease] t2-streamanalytics-2022-01-06-51238 (#22356)

* CodeGen from PR 17260 in Azure/azure-rest-api-specs
Update readme.python.md (#17260)

* version,CHANGELOG

* Update CHANGELOG.md

* Update _version.py

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* t2-netapp-2021-08-01 (#22316)

* CodeGen from PR 16381 in Azure/azure-rest-api-specs
[NetAppFiles] Anf 16015 net app files 2021-08-01 (#16381)

* Add 2021-08-01 folder

* Bump to api-version 2021-08

* Apply cahnges to api-version 2021-08

* Apply changes to api-version 2021-08

* Add VolumeGroups API

* prettier

* Add VolumeGroups API

* Update volumeType desciption

* Remove Name from backupPolicyPropertyBag

* Remove Name from backupPolicy Examples

* version,CHANGELOG

* test

* Sync eng/common directory with azure-sdk-tools for PR 2327 (#22021)

* new recordings

* Update CHANGELOG.md

* merge main

* Update shared_requirements.txt

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

* [AutoRelease] t2-notificationhubs-2022-01-06-74264 (#22359)

* CodeGen from PR 17259 in Azure/azure-rest-api-specs
Update readme.python.md (#17259)

* version,CHANGELOG

* test

* Update CHANGELOG.md

* Update _version.py

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Perf] Fix batch sizes in SampleBatchTest (#22352)

* Handle skipping docker build when PushImages is set and there is no dockerfile (#22107)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* drop Python 2.7/3.6 (#22320)

* [Key Vault] Drop 2.7, 3.6 support (#22367)

* Fixed the printing message. (#22301)

* synapse artifacts jan updates (#22306)

* synapse artifacts jan updates

* SHA 949388b

* update changelog

* [AutoRelease] t2-compute-2022-01-06-94013 (#22364)

* CodeGen from PR 17254 in Azure/azure-rest-api-specs
Compute add batch tag package-2021-08-01 (#17254)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [ServiceBus&EventHubs] remove RetryMode enum (#22369)

* remove RetryMode from SB

* remove RetryMode from EH

* annas comments

* delete web2021-02-01 (#22375)

* Hotfix for pipeline python version 2.7/3.6 task issues (#22363)

* excluded pypy3 tests run to avoid pipeline failure due to dropping support 2.7/3.6

* msrest version fixed for sms&phonenumber packages

* azure-mgmt-core version fixed for azure-mgmt-communication package

* analyzing task fail fix

* excluded 2.7/3.6 tests run to avoid pipeline failure due to dropping support 2.7/3.6

* removed unneccessary config from test.yml

* azure-mgmt-core version reverted for azure-mgmt-communication

* fixed dependency conflicts

Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-2660OE9.corp.microsoft.com>
Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-TLPRG45.reddog.microsoft.com>

* update to uamqp 1.5.0 (#22348)

* revert the change of bumping dep version (#22382)

* [textanalytics] run pyupgrade on textanalytics (#22344)

* run pyupgrade on samples

* run pyupgrade on tests

* run pyupgrade on src code

* fix mock import and pylint

* [KV] Remove metapackage from ci.yml (#22385)

* Update README.md (#22345)

* Remove py27 and py36 from all test matrices. Leave py27 testing enabled for core. (#22388)

* remove py27 and py36 from all test matrices. leave py27 testing enabled for core

* [ServiceBus] expand kwargs in public API (#22353)

* inital expand kwargs w/o mgmt models

* fix mypy/pylint

* mypy

* adam + anna comments

* lint

* lint bad whitespace

* remove retry

* adams comments

* lint

* Update text analytics live test config to support sovereign cloud testing (#22376)

* [metricsadvisor] convert to test proxy (#21974)

* update sync base testcases and conftest to use test proxy

* remove dep on unittest

* add sanitizers for test secrets

* convert one test

* fix weird spacing

* refactor base testcase into preparer

* convert test_alert_config.py + recordings

* recordings

* updates for aad tests

* test_credential and test_credential_entities, no recordings b/c need to fix sanitizer

* add rstrip / to client endpoint

* convert data_feed_ingestion

* convert data_feeds

* convert detection_config

* convert hooks

* update ma client tests

* refactor to simplify base test class and secrets needed

* refactor, parametrize auth option

* refactor / parametrize async + add preparer

* convert async tests to proxy

* add oauth sanitizer

* add test proxy to ci.yaml

* update testcases and have proxy auto start

* rename test_id -> ids, fix clean up so we raise better errors, add more randomization in names

* rerecord and delete old recordings

* rename tests to fix max path length and try removing max parallel for live tests

* ugh fix for py2.7

* fix envars for live tests

* fixes for live tests

* adjust list data feeds tests to be less flaky

* add rstrip before sanitizing

* Sync eng/common directory with azure-sdk-tools for PR 2500 (#22395)

* Update pipeline generator tool feed to azure-sdk-for-net

* Update pipeline generator tool version

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* add assignee (#22400)

* [metricsadvisor] shorten recording names (#22412)

* shorten recording names

* rename the sync recordings

* release failed because release date is too far away. (#22413)

* disable detect api changes RE #22416 (#22417)

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
Co-authored-by: Baher Abdullah <86964919+BaherAbdullah@users.noreply.github.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azpycli@microsoft.com>
Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Mita Garg <v-migarg@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: BigCat20196 <1095260342@qq.com>
Co-authored-by: Hödd <hodd@netapp.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Co-authored-by: Aigerim <aykobb@gmail.com>
Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-2660OE9.corp.microsoft.com>
Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-TLPRG45.reddog.microsoft.com>
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Co-authored-by: giakas <giakas@microsoft.com>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@catalinaperalta @rakshith91
[formrecognizer] Fix test assert for changing description value (Azur…
ffdc552 
…e#22324)

* fix assert for changing description value

* fix advanced samples file reference

* skip copy model samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

Assignees
No one assigned
Labels
Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catalinaperalta @kristapratico