Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricsadvisor] shorten recording names #22412

Merged
merged 2 commits into from
Jan 10, 2022
Merged

[metricsadvisor] shorten recording names #22412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1deb61c
shorten recording names
kristapratico Jan 10, 2022
aa5a7dc
rename the sync recordings
kristapratico Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdk/metricsadvisor/azure-ai-metricsadvisor/tests/async_tests/test_alert_config_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ async def test_create_alert_config_snooze_condition(self, client, variables):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy_async
async def test_create_alert_config_whole_series_alert_dir_both(self, client, variables):
async def test_create_alert_conf_whole_series_dir_both(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -345,7 +345,7 @@ async def test_create_alert_config_whole_series_alert_dir_both(self, client, var
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy_async
async def test_create_alert_config_whole_series_alert_dir_down(self, client, variables):
async def test_create_alert_conf_whole_series_dir_down(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -435,7 +435,7 @@ async def test_create_alert_config_whole_series_alert_dir_up(self, client, varia
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy_async
async def test_create_alert_config_whole_series_severity_condition(self, client, variables):
async def test_create_alert_config_whole_series_sev_cond(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -476,7 +476,7 @@ async def test_create_alert_config_whole_series_severity_condition(self, client,
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy_async
async def test_create_alert_config_series_group_alert_dir_both(self, client, variables):
async def test_create_alert_conf_series_group_dir_both(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -524,7 +524,7 @@ async def test_create_alert_config_series_group_alert_dir_both(self, client, var
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy_async
async def test_create_alert_config_series_group_alert_dir_down(self, client, variables):
async def test_create_alert_conf_series_group_dir_down(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -618,7 +618,7 @@ async def test_create_alert_config_series_group_alert_dir_up(self, client, varia
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy_async
async def test_create_alert_config_series_group_severity_condition(self, client, variables):
async def test_create_alert_conf_series_group_sev_cond(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down
2 changes: 1 addition & 1 deletion ...etricsadvisor/azure-ai-metricsadvisor/tests/async_tests/test_data_feed_ingestion_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async def test_list_data_feed_ingestion_status(self, client):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer()
@recorded_by_proxy_async
async def test_list_data_feed_ingestion_status_with_skip(self, client):
async def test_list_data_feed_ingest_status_skip(self, client):
async with client:
ingestions = client.list_data_feed_ingestion_status(
data_feed_id=self.data_feed_id,
Expand Down
8 changes: 4 additions & 4 deletions sdk/metricsadvisor/azure-ai-metricsadvisor/tests/async_tests/test_detection_config_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ async def test_create_ad_config_whole_series_detection(self, client, variables):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True)
@recorded_by_proxy_async
async def test_create_ad_config_with_series_and_group_conds(self, client, variables):
async def test_create_ad_conf_series_and_group_cond(self, client, variables):
detection_config_name = self.create_random_name("testdetectionconfig")
if self.is_live:
variables["detection_config_name"] = detection_config_name
Expand Down Expand Up @@ -213,7 +213,7 @@ async def test_create_ad_config_with_series_and_group_conds(self, client, variab
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True)
@recorded_by_proxy_async
async def test_create_ad_config_multiple_series_and_group_conds(self, client, variables):
async def test_create_ad_conf_series_and_group_conds(self, client, variables):
detection_config_name = self.create_random_name("testdetectionconfig")
if self.is_live:
variables["detection_config_name"] = detection_config_name
Expand Down Expand Up @@ -660,7 +660,7 @@ async def test_update_detection_config_with_kwargs(self, client, variables):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy_async
async def test_update_detection_config_with_model_and_kwargs(self, client, variables):
async def test_update_ad_conf_model_and_kwargs(self, client, variables):
async with client:
try:
detection_config = await client.get_detection_configuration(variables["detection_config_id"])
Expand Down Expand Up @@ -778,7 +778,7 @@ async def test_update_detection_config_with_model_and_kwargs(self, client, varia
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy_async
async def test_update_detection_config_by_resetting_properties(self, client, variables):
async def test_update_ad_conf_by_reset_props(self, client, variables):
async with client:
try:
update_name = "update" + str(uuid.uuid4())
Expand Down
0 ...fig_series_group_alert_dir_both[AAD].json → ...lert_conf_series_group_dir_both[AAD].json
View file
Open in desktop
File renamed without changes.
0 ..._series_group_alert_dir_both[APIKey].json → ...t_conf_series_group_dir_both[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...fig_series_group_alert_dir_down[AAD].json → ...lert_conf_series_group_dir_down[AAD].json
View file
Open in desktop
File renamed without changes.
0 ..._series_group_alert_dir_down[APIKey].json → ...t_conf_series_group_dir_down[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...series_group_severity_condition[AAD].json → ...lert_conf_series_group_sev_cond[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...ies_group_severity_condition[APIKey].json → ...t_conf_series_group_sev_cond[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...fig_whole_series_alert_dir_both[AAD].json → ...lert_conf_whole_series_dir_both[AAD].json
View file
Open in desktop
File renamed without changes.
0 ..._whole_series_alert_dir_both[APIKey].json → ...t_conf_whole_series_dir_both[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...fig_whole_series_alert_dir_down[AAD].json → ...lert_conf_whole_series_dir_down[AAD].json
View file
Open in desktop
File renamed without changes.
0 ..._whole_series_alert_dir_down[APIKey].json → ...t_conf_whole_series_dir_down[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...whole_series_severity_condition[AAD].json → ...rt_config_whole_series_sev_cond[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...le_series_severity_condition[APIKey].json → ...config_whole_series_sev_cond[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...feed_ingestion_status_with_skip[AAD].json → ...st_data_feed_ingest_status_skip[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...d_ingestion_status_with_skip[APIKey].json → ...data_feed_ingest_status_skip[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...fig_with_series_and_group_conds[AAD].json → ...e_ad_conf_series_and_group_cond[AAD].json
View file
Open in desktop
File renamed without changes.
0 ..._with_series_and_group_conds[APIKey].json → ...d_conf_series_and_group_cond[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...multiple_series_and_group_conds[AAD].json → ..._ad_conf_series_and_group_conds[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...tiple_series_and_group_conds[APIKey].json → ..._conf_series_and_group_conds[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ..._config_by_resetting_properties[AAD].json → ...t_update_ad_conf_by_reset_props[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...nfig_by_resetting_properties[APIKey].json → ...pdate_ad_conf_by_reset_props[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...on_config_with_model_and_kwargs[AAD].json → ...update_ad_conf_model_and_kwargs[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...config_with_model_and_kwargs[APIKey].json → ...ate_ad_conf_model_and_kwargs[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...ries_group_alert_direction_both[AAD].json → ...lert_conf_series_group_dir_both[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...s_group_alert_direction_both[APIKey].json → ...t_conf_series_group_dir_both[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...ries_group_alert_direction_down[AAD].json → ...lert_conf_series_group_dir_down[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...s_group_alert_direction_down[APIKey].json → ...t_conf_series_group_dir_down[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...series_group_severity_condition[AAD].json → ...lert_conf_series_group_sev_cond[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...ies_group_severity_condition[APIKey].json → ...t_conf_series_group_sev_cond[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...ole_series_alert_direction_both[AAD].json → ...lert_conf_whole_series_dir_both[AAD].json
View file
Open in desktop
File renamed without changes.
0 ..._series_alert_direction_both[APIKey].json → ...t_conf_whole_series_dir_both[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...ole_series_alert_direction_down[AAD].json → ...lert_conf_whole_series_dir_down[AAD].json
View file
Open in desktop
File renamed without changes.
0 ..._series_alert_direction_down[APIKey].json → ...t_conf_whole_series_dir_down[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...whole_series_severity_condition[AAD].json → ...rt_config_whole_series_sev_cond[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...le_series_severity_condition[APIKey].json → ...config_whole_series_sev_cond[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...feed_ingestion_status_with_skip[AAD].json → ...st_data_feed_ingest_status_skip[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...d_ingestion_status_with_skip[APIKey].json → ...data_feed_ingest_status_skip[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...fig_with_series_and_group_conds[AAD].json → ...e_ad_conf_series_and_group_cond[AAD].json
View file
Open in desktop
File renamed without changes.
0 ..._with_series_and_group_conds[APIKey].json → ...d_conf_series_and_group_cond[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...multiple_series_and_group_conds[AAD].json → ..._ad_conf_series_and_group_conds[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...tiple_series_and_group_conds[APIKey].json → ..._conf_series_and_group_conds[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ..._config_by_resetting_properties[AAD].json → ...t_update_ad_conf_by_reset_props[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...nfig_by_resetting_properties[APIKey].json → ...pdate_ad_conf_by_reset_props[APIKey].json
View file
Open in desktop
File renamed without changes.
0 ...on_config_with_model_and_kwargs[AAD].json → ...update_ad_conf_model_and_kwargs[AAD].json
View file
Open in desktop
File renamed without changes.
0 ...config_with_model_and_kwargs[APIKey].json → ...ate_ad_conf_model_and_kwargs[APIKey].json
View file
Open in desktop
File renamed without changes.
12 changes: 6 additions & 6 deletions sdk/metricsadvisor/azure-ai-metricsadvisor/tests/test_alert_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def test_create_alert_config_snooze_condition(self, client, variables):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy
def test_create_alert_config_whole_series_alert_direction_both(self, client, variables):
def test_create_alert_conf_whole_series_dir_both(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -341,7 +341,7 @@ def test_create_alert_config_whole_series_alert_direction_both(self, client, var
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy
def test_create_alert_config_whole_series_alert_direction_down(self, client, variables):
def test_create_alert_conf_whole_series_dir_down(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -431,7 +431,7 @@ def test_create_alert_config_whole_series_alert_direction_up(self, client, varia
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy
def test_create_alert_config_whole_series_severity_condition(self, client, variables):
def test_create_alert_config_whole_series_sev_cond(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -472,7 +472,7 @@ def test_create_alert_config_whole_series_severity_condition(self, client, varia
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy
def test_create_alert_config_series_group_alert_direction_both(self, client, variables):
def test_create_alert_conf_series_group_dir_both(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -520,7 +520,7 @@ def test_create_alert_config_series_group_alert_direction_both(self, client, var
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy
def test_create_alert_config_series_group_alert_direction_down(self, client, variables):
def test_create_alert_conf_series_group_dir_down(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down Expand Up @@ -614,7 +614,7 @@ def test_create_alert_config_series_group_alert_direction_up(self, client, varia
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy
def test_create_alert_config_series_group_severity_condition(self, client, variables):
def test_create_alert_conf_series_group_sev_cond(self, client, variables):
alert_config_name = self.create_random_name("alertconfig")
if self.is_live:
variables["alert_config_name"] = alert_config_name
Expand Down
2 changes: 1 addition & 1 deletion sdk/metricsadvisor/azure-ai-metricsadvisor/tests/test_data_feed_ingestion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_list_data_feed_ingestion_status(self, client):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer()
@recorded_by_proxy
def test_list_data_feed_ingestion_status_with_skip(self, client):
def test_list_data_feed_ingest_status_skip(self, client):

ingestions = client.list_data_feed_ingestion_status(
data_feed_id=self.data_feed_id,
Expand Down
8 changes: 4 additions & 4 deletions sdk/metricsadvisor/azure-ai-metricsadvisor/tests/test_detection_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def test_create_ad_config_whole_series_detection(self, client, variables):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True)
@recorded_by_proxy
def test_create_ad_config_with_series_and_group_conds(self, client, variables):
def test_create_ad_conf_series_and_group_cond(self, client, variables):
detection_config_name = self.create_random_name("testdetectionconfig")
if self.is_live:
variables["detection_config_name"] = detection_config_name
Expand Down Expand Up @@ -206,7 +206,7 @@ def test_create_ad_config_with_series_and_group_conds(self, client, variables):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True)
@recorded_by_proxy
def test_create_ad_config_multiple_series_and_group_conds(self, client, variables):
def test_create_ad_conf_series_and_group_conds(self, client, variables):
detection_config_name = self.create_random_name("testdetectionconfig")
if self.is_live:
variables["detection_config_name"] = detection_config_name
Expand Down Expand Up @@ -643,7 +643,7 @@ def test_update_detection_config_with_kwargs(self, client, variables):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy
def test_update_detection_config_with_model_and_kwargs(self, client, variables):
def test_update_ad_conf_model_and_kwargs(self, client, variables):
try:
detection_config = client.get_detection_configuration(variables["detection_config_id"])
change_threshold_condition = ChangeThresholdCondition(
Expand Down Expand Up @@ -759,7 +759,7 @@ def test_update_detection_config_with_model_and_kwargs(self, client, variables):
@pytest.mark.parametrize("credential", CREDENTIALS, ids=ids)
@MetricsAdvisorPreparer(data_feed=True, detection_config=True)
@recorded_by_proxy
def test_update_detection_config_by_resetting_properties(self, client, variables):
def test_update_ad_conf_by_reset_props(self, client, variables):
try:
update_name = "update" + str(uuid.uuid4())
if self.is_live:
Expand Down