Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove vscodecred #25493

Merged
merged 5 commits into from
Aug 1, 2022
Merged

remove vscodecred #25493

merged 5 commits into from
Aug 1, 2022

Conversation

xiangyan99
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Azure.Identity label Aug 1, 2022
@billwert
Copy link
Contributor

billwert commented Aug 1, 2022

I don't believe the mermaid SVG is automatically generated and you need to add it to this PR. @scottaddie ?

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

@xiangyan99
Copy link
Member Author

/azp run python - identity - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiangyan99 xiangyan99 merged commit 8a03bff into main Aug 1, 2022
@xiangyan99 xiangyan99 deleted the identity_remove_vscode_cred_from_dac branch August 1, 2022 21:18
@billwert billwert mentioned this pull request Aug 16, 2022
Closed
4 tasks
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
@xiangyan99 @wonder6845
remove vscodecred (Azure#25493)
c93bd93 
* remove vscodecred

* update

* update

* update

* update
@scottaddie scottaddie mentioned this pull request Sep 13, 2022
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Nov 10, 2023
@alexkarcher-msft @dannysongg
@vishal1997 @crosenblatt @sushmithavangala @rohinisharma @mukundnigam @kamperiadis @ha0ch1
CodeGen from PR 26545 in Azure/azure-rest-api-specs
6d8a19a 
Release web 2023 01 01 (Azure#26545)

* Add new api-version 2023-01-01 (Azure#22962)

* Add new api-version 2023-01-01

* Change default package api-version

* Updated workflowstate to be a reference (Azure#23084)

* Fix OneDeploy request and response bodies (Azure#23224)

* Fix OneDeploy request and response bodies

* Fixing typo

* Add Container Apps Environment Id in checknameavailability API (Azure#24102)

Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>

* Add minTlsCipherSuite property (Azure#24198)

* Add minTlsCipherSuite property

* Move to SiteConfig

---------

Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>

* Dapr configuration for a site (Azure#24606)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

---------

Co-authored-by: Sushmitha Vangala <svangala@microsoft.com>

* Fix for JS SDK check failure for Dapr Config (Azure#25493)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

* JS Sdk check fail fix

---------

Co-authored-by: Sushmitha Vangala <svangala@microsoft.com>

* Release web 2023 01 01 (Azure#25157)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a1110765d08c5c96d65f884237313515d842586.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

---------

Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com>

* Release web 2023 01 01 (Azure#25629)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a1110765d08c5c96d65f884237313515d842586.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

* Removing quota type parameter

---------

Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com>

* Adding workload profile & resource config to Site (Azure#25868)

* Adding workload profile & resource config to Site

* prettier fix

* cosmetic fix

* updating examples

* prettier fix

* Fix Python SDK failure for Dapr log level config (Azure#26198)

* Rename log level enum for dapr

* Fix Python SDK failure for Dapr log level config

* Rename log level num for dapr (Azure#26374)

* Rename log level num for dapr

* Rename log level num for dapr

* initial change to add ase regions (Azure#26333)

* initial change to add ase regions

* addressing comments

* nit adding example as suggested

* formatting code

* add custom word

* prettier everything

* prettier everything

* Revert "Fix OneDeploy request and response bodies (Azure#23224)" (Azure#26580)

This reverts commit 7dfc303ee18440ee5eede155bb0d63797fbdc4bb.

---------

Co-authored-by: Alex Karcher <alkarche@microsoft.com>
Co-authored-by: dannysongg <38927254+dannysongg@users.noreply.github.com>
Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com>
Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>
Co-authored-by: Chris Rosenblatt <rosench13@gmail.com>
Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
Co-authored-by: SushmithaVReddy <sushmithavangala@gmail.com>
Co-authored-by: Sushmitha Vangala <svangala@microsoft.com>
Co-authored-by: rohinisharma <rohini2@illinois.edu>
Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com>
Co-authored-by: mukundnigam <34106498+mukundnigam@users.noreply.github.com>
Co-authored-by: Kirstyn Amperiadis <102087132+kamperiadis@users.noreply.github.com>
Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billwert billwert billwert approved these changes

@mccoyp mccoyp Awaiting requested review from mccoyp

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiangyan99 @billwert @azure-sdk