Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add read to datalake StorageStreamDownloader #25707

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

jalauzon-msft
Copy link
Member

As a follow-up to #24275, this adds the read method to the StorageStreamDownloader for datalake. This was fairly trivial since datalake's downloader just calls into blob. Added one basic test to ensure functionality but more advanced testing is handled in blob tests.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Aug 15, 2022
Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this! Glad you were able to double dip the benefits for all the effort you put in for Blob 😄

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-file-datalake

@jalauzon-msft jalauzon-msft merged commit ba5059c into Azure:main Aug 15, 2022
@jalauzon-msft jalauzon-msft deleted the datalake-read branch August 15, 2022 22:30
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants