Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Support queue settings property for command jobs #29159

Merged
merged 18 commits into from
Mar 7, 2023
Merged

[ML] Support queue settings property for command jobs #29159

merged 18 commits into from
Mar 7, 2023

Conversation

vivijay91
Copy link
Contributor

@vivijay91 vivijay91 commented Mar 6, 2023 •
edited
Loading

Description

Added QueueSettings schema and entity. Updated command job schema to use queue settings.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@vivijay91 vivijay91 changed the title Add queue_settings to jobs [ML] Support queue settings property for command jobs Mar 6, 2023
@zhengfeiwang
Copy link
Member

For CommandJob._to_node in entities/_job/command_job.py, need to pass in queue_settings for the returning Command.

@luigiw luigiw merged commit beea3b1 into Azure:main Mar 7, 2023
@zhengfeiwang zhengfeiwang mentioned this pull request Mar 8, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengfeiwang zhengfeiwang zhengfeiwang left review comments

@TonyJ1 TonyJ1 TonyJ1 left review comments

@luigiw luigiw luigiw approved these changes

@hugoaponte hugoaponte Awaiting requested review from hugoaponte

@Man-MSFT Man-MSFT Awaiting requested review from Man-MSFT

@banibrata banibrata Awaiting requested review from banibrata

@wangchao1230 wangchao1230 Awaiting requested review from wangchao1230 wangchao1230 is a code owner

@DouglasXiaoMS DouglasXiaoMS Awaiting requested review from DouglasXiaoMS

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@harneetvirk harneetvirk Awaiting requested review from harneetvirk

@kdestin kdestin Awaiting requested review from kdestin

@MilesHolland MilesHolland Awaiting requested review from MilesHolland

@needuv needuv Awaiting requested review from needuv

@nemanjarajic nemanjarajic Awaiting requested review from nemanjarajic

@nthandeMS nthandeMS Awaiting requested review from nthandeMS

@kristapratico kristapratico Awaiting requested review from kristapratico

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

@yogeshmo yogeshmo Awaiting requested review from yogeshmo

Assignees
No one assigned
Labels
Machine Learning ML-Assets ML-Jobs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivijay91 @azure-sdk @zhengfeiwang @luigiw @TonyJ1