switch tooling over to typespec #29501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msyyc
requested changes
Mar 22, 2023
There was a problem hiding this comment.
we shall wait for other language together and test it before merge so block it temporarily.
java: https://github.com/Azure/azure-sdk-for-java/pull/34136/files
…into typespec_gen_script
benbp
reviewed
Mar 23, 2023
msyyc
approved these changes
Mar 24, 2023
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 27, 2023
…into network_ga * 'main' of https://github.com/Azure/azure-sdk-for-python: (63 commits) check only once whether artifact extension exists (Azure#29594) code and test (Azure#29530) fix: support data binding expression for resources.xxx (Azure#29559) code and test (Azure#29558) [ServiceBus] enable sovereign cloud testing (Azure#29202) [AutoRelease] t2-communication-2023-03-20-22792(can only be merged by SDK owner) (Azure#29453) [Identity] Allow configurable process timeouts (Azure#28290) Increment package version after release of azure-containerregistry (Azure#29582) Update optional (Azure#28435) [Monitor][Query] Add sample notebook for large queries (Azure#28148) Update CHANGELOG.md (Azure#29580) [ServiceBus] remove msrest (Azure#29324) Explicitly set PSNativeCommandArgumentPassing to Legacy for git push script (Azure#29554) [ML][Pipelines] Support queue settings in pipeline job (Azure#29209) add experimental decorator for datatransfer (Azure#29562) Featurestore/online store crud new pr (Azure#29546) switch tooling over to typespec (Azure#29501) set up base path for feature set in load function (Azure#29544) Address credential description in docstring (Azure#29549) [Monitor] Regen query and ingestion (Azure#29504) ...
weshaggard
reviewed
Mar 31, 2023
| @@ -1,127 +0,0 @@ | |||
| # For details see https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/Cadl-Project-Scripts.md | |||
There was a problem hiding this comment.
You should not be deleting files under eng\common directly in a language repo. In fact I don't know how this didn't fail as we have a CI check for this. I've filed a bug to investigate this.
There was a problem hiding this comment.
I got this back in sync with #29772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines