[AppConfig] Fix flaky tests #30577
Merged
[AppConfig] Fix flaky tests #30577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YalinLi0312
added
Client
|
API change check API changes are not detected in this pull request. |
xiangyan99
reviewed
May 31, 2023
sdk/appconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client.py
Outdated
Show resolved
Hide resolved
xiangyan99
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accept_timeis pretty flaky, it assumes the number of configuration settings on one day ago should be less than the number of configuration settings listing at current time(without passing parameteraccept_time). The assumption is not always correct, for example, when there are some configuration settings created and deleted one day ago, we can still get the configuration settings in the list result withaccept_timeequals to one day ago, but it is no longer in the list result at current time. So it doesn't make sense to compareall_inclusivevsexclude_today. Also updated the sample test in docstring.accept_timein docstring to be more clearer.