Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK Automation] Establish base line for SDK automation for TypeSpecs #8858

Closed
raych1 opened this issue Aug 20, 2024 · 4 comments
Closed

[SDK Automation] Establish base line for SDK automation for TypeSpecs #8858

raych1 opened this issue Aug 20, 2024 · 4 comments
Assignees

Comments

@raych1
Copy link
Member

raych1 commented Aug 20, 2024

Objective
Establish a baseline for the SDK automation results, which will be used as a reference for future SDK automation runs.

Task

  • Execute SDK automation for all TypeSpecs in the specification repository.
  • Identify any issues reported by the SDK automation.
  • Implement necessary fixes based on the identified issues.

Spec PRs created covering all TypeSpecs
test-repo-billy/azure-rest-api-specs#3481
test-repo-billy/azure-rest-api-specs#3482
test-repo-billy/azure-rest-api-specs#3485
test-repo-billy/azure-rest-api-specs#3486
test-repo-billy/azure-rest-api-specs#3487
test-repo-billy/azure-rest-api-specs#3489
test-repo-billy/azure-rest-api-specs#3490

@raych1 raych1 self-assigned this Aug 20, 2024
@wanlwanl
Copy link
Member

wanlwanl commented Aug 23, 2024

JS SDK Generation Test Summary

sdk sutomation stage may mark success even though it contains generation failures.

Batches Status

Invalid emitter settings

Lack of required options. The correct settings should be:

Required Shared Parameters

e.g.

parameters:
  "service-dir":
    default: "sdk/openai"

If folders are shared between package, define e.g.

  "dependencies":
    "additionalDirectories":
      - "specification/contosowidgetmanager/Contoso.WidgetManager.Shared/"
    default: ""

Modular

e.g.

  "@azure-tools/typespec-ts":
    generateMetadata: true
    generateSample: true
    generateTest: true
    azureSdkForJs: true
    isModularLibrary: true
    experimentalExtensibleEnums: true
    enableOperationGroup: true
    hierarchyClient: false
    package-dir: "openai-assistants"
    packageDetails:
      name: "@azure/openai-assistants"
    flavor: azure

RLC

e.g.

  "@azure-tools/typespec-ts":
    generateMetadata: true
    generateSample: true
    generateTest: true
    azureSdkForJs: true
    package-dir: "ai-content-safety-rest"
    packageDetails:
      name: "@azure-rest/ai-content-safety"
      version: "1.0.0"
      description: "ContentSafety Service"
    flavor: azure

@raych1
Copy link
Member Author

raych1 commented Oct 4, 2024

DotNet issues are tracked at here,
Java confirms the issue reported are all service spec or configuration issue.
Go all looks fine for the run result.

All the baseline has been collected, and we will work on the issue fixes tracked by other tasks.

@raych1
Copy link
Member Author

raych1 commented Oct 4, 2024

the

@raych1 raych1 closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants