fix-special-union-within-anonymous-model-issue #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
commented
Aug 26, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiaozha
commented
Aug 26, 2024
qiaozha
commented
Aug 27, 2024
...es/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/models/models.ts
Show resolved
Hide resolved
MaryGao
reviewed
Aug 28, 2024
| @@ -1035,6 +1035,198 @@ describe("modular special union serialization", () => { | |||
| true | |||
| ); | |||
| }); | |||
|
|
|||
| it("should generate serialize util if there're special discriminated union within a anonymous model", async () => { | |||
There was a problem hiding this comment.
Could you simplify this case with the root issue maybe removing un-necessary doc and decorators? Does the anomymous model happen in body type?
There was a problem hiding this comment.
I don't like the idea of directly copying the spec into our UTs because this would introduce a lot of un-necessary changes and also not good for review. we may have plan to remove smoke tests and add more IT or UTs. if these test cases are not small, we may not be effective either.
wanlwanl
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2768
fixes #2772