Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Pylint guidelines checker from sdk-for-python to here #3078

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Apr 6, 2022

@tjprescott just FYI

Can you please try using the external package (instead of the inserted into path as seen in rcfile usage?)

  • There are a couple test failures that are outstanding that I need to address (they are pointed at non-existent guidelines pages now due to rework of azure-sdk github.io page)
  • I also need to rename from pylint_custom_plugin to pylint_guidelines_checker.

@scbedd scbedd requested a review from a team as a code owner April 6, 2022 00:52
@tjprescott
Copy link
Member

Adding @l0lawrence as reviewer since she's working on pylint plugin stuff as well.

@tjprescott
Copy link
Member

Also I think @l0lawrence already had a PR that fixed the broken links.

@scbedd scbedd self-assigned this Apr 7, 2022
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Apr 7, 2022
@check-enforcer-staging
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

… targeted files. Update targeted folder in guidelines checker ci.yml.
@weshaggard weshaggard merged commit b3fb522 into main Apr 20, 2022
@weshaggard weshaggard deleted the feature/pylint-plugin branch April 20, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants