Use the batch version of ValidateDocsMsPackagesFn #3169
Conversation
|
The following pipelines have been queued for testing: |
| foreach ($packageInfoLocation in $PackageInfoJsonLocations) { | ||
| Write-Host "Updating metadata for package: $packageInfoLocation" | ||
| # Convert package metadata json file to metadata json property. | ||
| $packageInfo = GetPackageInfoJson $packageInfoLocation |
There was a problem hiding this comment.
We cannot remove this without breaking the other languages until they each are updated to start passing in this new parameter. What is our transition plan?
There was a problem hiding this comment.
Each of the language-settings files that implemented $ValidateDocsMsPackagesFn have been shimmed to support single packageInfo and multiple packageInfos parameters:
Azure/azure-sdk-for-js#21483
Azure/azure-sdk-for-java#28346
Azure/azure-sdk-for-python#24041
There was a problem hiding this comment.
The yaml and powershell script for Update-DocsMsMetadata already supported multiple package info locations. The implementation steps are:
- Add batch support to the language repos (language repo prs)
- Add batch invocation to eng/common (this pr)
- Optimize batch processing per language
- Pass multiple packageInfoLocations to
update-docsms-metadata.yml - Use deeper batch processing in
Validate-{language}-DocMsPackages
- Pass multiple packageInfoLocations to
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Refactor `Update-DocsMsMetadata.ps1` to support batch processing in `$ValidateDocsMsPackagesFn` It appears that only azure-sdk-for-java and azure-sdk-for-python implement `$ValidateDocsMsPackagesFn`. Both repos have been updated to support the `-PackageInfos` parameter to `$ValidateDocsMsPackagesFn`
Refactor
Update-DocsMsMetadata.ps1to support batch processing in$ValidateDocsMsPackagesFnIt appears that only azure-sdk-for-java and azure-sdk-for-python implement
$ValidateDocsMsPackagesFn. Both repos have been updated to support the-PackageInfosparameter to$ValidateDocsMsPackagesFn