Fix null errors in SetTestPipelineVersion #3546
Conversation
chidozieononiwu
commented
Jun 30, 2022
chidozieononiwu
commented
- Fix null errors in SetTestPipelineVersion
- Rename Publish Packages to Upload Packages in azuresdkpartnerdrops-to-nugetfeed.yml
chidozieononiwu
requested review from
sima-zhu,
weshaggard,
benbp and
a team
as code owners
|
The following pipelines have been queued for testing: |
eng/pipelines/templates/jobs/azuresdkpartnerdrops-to-nugetfeed.yml
Outdated
Show resolved
Hide resolved
chidozieononiwu
force-pushed
the
bugFix/MiscIssues
branch
from
c4d9d27
to
ec310dc
Compare
|
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
I've got individual requests inline but, in general, I'd like a little more verbosity to this. Change the LogDebug statements to Write-Host or something that's always being output. The versioning setting commands notwithstanding, this command doesn't produce enough output where LogDebug is necessary. I'd also like to see the arguments being passed in, echoed back along with the git tag -l that it's going to be running.
chidozieononiwu
force-pushed
the
bugFix/MiscIssues
branch
from
ec310dc
to
9292e45
Compare
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
bugFix/MiscIssues
branch
from
9292e45
to
9be9e55
Compare
|
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Approved as per our conversation. Thank you for making the updates @chidozieononiwu!
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
