-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip env processing on matrix import step #7854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, def makes sense. Thanks @benbp
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7854 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Matrix filters are intended to work against the environment variable key, not the resolved value. There is a bug where resolve environment variables on an imported matrix, before processing any matrix filters passed in from the top level. This PR changes import behavior to skip env var lookup until after the imported matrix has been combined with the parent matrix.