Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal fix for operation rename issue for HLC -> Modular client #8436

Merged
merged 21 commits into from
Jun 21, 2024
Merged

Minimal fix for operation rename issue for HLC -> Modular client #8436

merged 21 commits into from
Jun 21, 2024

Conversation

wanlwanl
Copy link
Member

No description provided.

@wanlwanl wanlwanl changed the title Quick fix operation rename issue for HLC -> Modular client Minimal fix for operation rename issue for HLC -> Modular client Jun 13, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@wanlwanl
Copy link
Member Author

@qiaozha @MaryGao check it out: https://github.com/Azure/azure-sdk-tools/actions/runs/9562789336/job/26371377608?pr=8436
From now on, changelog will be output in github check, so for review, @kazrael2119 no need to run test manually in the future

@wanlwanl wanlwanl enabled auto-merge (squash) June 19, 2024 03:59
This was referenced Jun 19, 2024
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@wanlwanl
Copy link
Member Author

@MaryGao updated

MaryGao
MaryGao approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weshaggard weshaggard dismissed their stale review June 20, 2024 15:25

action was removed

@weshaggard
Copy link
Member

/azp run tools - js-sdk-release-tools - ci

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@weshaggard
Copy link
Member

FYI I the public ci devops job tools - js-sdk-release-tools - ci was disabled because it hadn't been ran for a more then 180 days, I renabled it. Once you resolve the conflicts here then it should trigger on the next push.

@wanlwanl wanlwanl enabled auto-merge (squash) June 21, 2024 02:33
@wanlwanl wanlwanl merged commit 16b6c25 into Azure:main Jun 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@albertxavier100 albertxavier100 albertxavier100 left review comments

@kazrael2119 kazrael2119 kazrael2119 left review comments

@MaryGao MaryGao MaryGao approved these changes

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wanlwanl @azure-sdk @raych1 @weshaggard @MaryGao @albertxavier100 @kazrael2119