Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET API review parser changes to use new token schema #8850

Merged

Conversation

praveenkuttappan
Copy link
Member

@praveenkuttappan praveenkuttappan commented Aug 18, 2024

This PR is to modify .NET API review parser to create tokens based on new schema that's outlined in the PR #8816

Goal is to simplify token schema structure. Above PR also has sample token JSON file created as per the schema.

PR for changes to token models: #8852

@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Aug 18, 2024
@praveenkuttappan praveenkuttappan self-assigned this Aug 18, 2024
@praveenkuttappan praveenkuttappan changed the title .NET API review parser chagnes to use new token schema .NET API review parser changes to use new token schema Aug 19, 2024
@praveenkuttappan
Copy link
Member Author

I have added test cases to verify generated schema for Azure.Template and Azure.Storage.Blobs.

@praveenkuttappan praveenkuttappan merged commit f5b732c into Azure:main Aug 22, 2024
14 checks passed
@praveenkuttappan praveenkuttappan deleted the csharp_parser_schema_changes branch August 22, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants