Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure copy to blobs #968

Merged
2 commits merged into from
Oct 19, 2020
Merged

Conversation

chidozieononiwu
Copy link
Member

Restructure location of language specific files

@weshaggard
Copy link
Member

I'm fine to do some testing of this but I'd like to wait until after release week before we merge this change in.

@chidozieononiwu
Copy link
Member Author

I'm fine to do some testing of this but I'd like to wait until after release week before we merge this change in.

I was going to do template releases off the Sync PRs.

@weshaggard
Copy link
Member

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ahsonkhan
Copy link
Member

ahsonkhan commented Sep 15, 2020

Any updates to this? Pinging since it is > 7 days old.

@weshaggard
Copy link
Member

@chidozieononiwu the changes look complete it is just a matter of whether or not you finished your testing.

@weshaggard
Copy link
Member

@mitchdenny @chidozieononiwu looks like the VerifyAndMerge stage timeout. We might need to use a custom environment for this pipeline and remove the 3d timeout https://dev.azure.com/azure-sdk/internal/_environments/26/checks.

@weshaggard
Copy link
Member

In the mean time you can run the script locally to merge the Sync PRs when ready.

@mitchdenny
Copy link
Contributor

@mitchdenny @chidozieononiwu looks like the VerifyAndMerge stage timeout. We might need to use a custom environment for this pipeline and remove the 3d timeout https://dev.azure.com/azure-sdk/internal/_environments/26/checks.

Setup the githibmerges environment with the same approver set, but a 30 day timeout (looks like they've gotten rid of infinite timeouts actually.

@ahsonkhan
Copy link
Member

ahsonkhan commented Sep 24, 2020

Any plans for this PR? It's been open in corresponding language repos for 2+ weeks now.

If it is not being worked on actively, consider closing it.

For example, currently, 6 out of 16 PRs in C are sync:
https://github.com/Azure/azure-sdk-for-c/pulls

A less visible approach, to make sure the approach/design of the implementation is solid, might be to first open a draft PR, get an initial look/feedback from reviewers like Wes, and then convert it to an actual PR which triggers the sync PRs to all the language repos. Hopefully, that way such PRs can be iterated on quickly and don't stay in a pending state for too long.

cc @RickWinter

@chidozieononiwu
Copy link
Member Author

Any plans for this PR? It's been open in corresponding language repos for 2+ weeks now.

If it is not being worked on actively, consider closing it.

For example, currently, 6 out of 16 PRs in C are sync:
https://github.com/Azure/azure-sdk-for-c/pulls

cc @RickWinter

I am still working on it. But other changes need to go in before this change can be merged. This is due to the fact we are still working on how to properly test eng/common changes across the language repos.

@ahsonkhan
Copy link
Member

I am still working on it. But other changes need to go in before this change can be merged.

In that case, does it make sense to temporarily close this PR, while it is blocked, and then re-open it once it is ready? Or are you finding some value in keeping it open?

@mitchdenny
Copy link
Contributor

Hey @ahsonkhan, one of the problems with cross cutting EngSys changes (particularly ones that could break pipelines) is that they take longer to implement. The PRs need to be open so that the changes can be validated.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments but otherwise looks good.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu
Copy link
Member Author

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Oct 19, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6f89ad5 into Azure:master Oct 19, 2020
@chidozieononiwu
Copy link
Member Author

/check-enforcer override

benbp pushed a commit that referenced this pull request Dec 1, 2020
Restructure location of language specific files
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants