-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure copy to blobs #968
Conversation
I'm fine to do some testing of this but I'd like to wait until after release week before we merge this change in. |
I was going to do template releases off the Sync PRs. |
/azp run azure-sdk-tools - sync - eng-common |
Azure Pipelines successfully started running 1 pipeline(s). |
58d5165
to
2aa969b
Compare
Any updates to this? Pinging since it is > 7 days old. |
@chidozieononiwu the changes look complete it is just a matter of whether or not you finished your testing. |
@mitchdenny @chidozieononiwu looks like the VerifyAndMerge stage timeout. We might need to use a custom environment for this pipeline and remove the 3d timeout https://dev.azure.com/azure-sdk/internal/_environments/26/checks. |
In the mean time you can run the script locally to merge the Sync PRs when ready. |
2aa969b
to
305ce1c
Compare
Setup the githibmerges environment with the same approver set, but a 30 day timeout (looks like they've gotten rid of infinite timeouts actually. |
Any plans for this PR? It's been open in corresponding language repos for 2+ weeks now. If it is not being worked on actively, consider closing it. For example, currently, 6 out of 16 PRs in C are sync: A less visible approach, to make sure the approach/design of the implementation is solid, might be to first open a draft PR, get an initial look/feedback from reviewers like Wes, and then convert it to an actual PR which triggers the sync PRs to all the language repos. Hopefully, that way such PRs can be iterated on quickly and don't stay in a pending state for too long. cc @RickWinter |
I am still working on it. But other changes need to go in before this change can be merged. This is due to the fact we are still working on how to properly test |
In that case, does it make sense to temporarily close this PR, while it is blocked, and then re-open it once it is ready? Or are you finding some value in keeping it open? |
Hey @ahsonkhan, one of the problems with cross cutting EngSys changes (particularly ones that could break pipelines) is that they take longer to implement. The PRs need to be open so that the changes can be validated. |
305ce1c
to
f7f09e8
Compare
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments but otherwise looks good.
81bda60
to
0b23b7b
Compare
The following pipelines have been queued for testing: |
0b23b7b
to
1cdef49
Compare
The following pipelines have been queued for testing: |
/azp run azure-sdk-tools - sync - eng-common |
Azure Pipelines successfully started running 1 pipeline(s). |
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
/check-enforcer override |
Restructure location of language specific files
Restructure location of language specific files