Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

MessageReceiver.RenewLockAsync() is not updating the LockedUntilUtc on the Message #245

Merged
merged 2 commits into from
Aug 3, 2017

Conversation

vinaysurya
Copy link
Member

No description provided.

@vinaysurya vinaysurya requested a review from a team as a code owner August 3, 2017 01:00
@codecov-io
Copy link

codecov-io commented Aug 3, 2017

Codecov Report

❗ No coverage uploaded for pull request base (dev@f5cfcb7). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #245   +/-   ##
======================================
  Coverage       ?   58.36%           
======================================
  Files          ?       82           
  Lines          ?     5901           
  Branches       ?      714           
======================================
  Hits           ?     3444           
  Misses         ?     2086           
  Partials       ?      371
Impacted Files Coverage Δ
...c/Microsoft.Azure.ServiceBus/MessageReceivePump.cs 67.6% <0%> (ø)
...Microsoft.Azure.ServiceBus/Core/MessageReceiver.cs 76.93% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cfcb7...f30a7b7. Read the comment docs.

@niemyjski
Copy link

To me it only makes sense to take an id to renew the lock and it's lighter weight. The current implementation needs work and is confusing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants