Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.10.3 #577

Merged
merged 8 commits into from
Apr 16, 2019
Merged

2.10.3 #577

merged 8 commits into from
Apr 16, 2019

Conversation

XiaoningLiu
Copy link
Member

No description provided.

dabutvin and others added 7 commits October 26, 2018 00:18
@dabutvin @vinjiang
remove comment about maxResults
e937bb6 
I am seeing it limit the results when using ListBlobs
@dabutvin @vinjiang
remove corresponding comments about about maxResults
8541848
@cpwinn @vinjiang
Remove retryInfo.retryable check in retrypolicyfilter.js (Azure#541)
11fcab5 
* Fix falsy handling in retrypolicyfilter.js

requestOptions.absorbConditionalErrorsOnRetry and retryInfo.retryable tend to be undefined unless set to false. So we need to only want for False values otherwise most errors won't retry.

* Update retrypolicyfilter.js

* remove retryInfo.retryable check since it will never be set at this line.

Co-Authored-By: cpwinn <clark.winn@gmail.com>
@MRayermannMSFT @vinjiang
Fix callback not being called in _getBlobToLocalFile
7624a9b
@XiaoningLiu
2.10.3 & 2.10.103
ebc422b
@XiaoningLiu
Fix changelog alignment issues
84ad050
@XiaoningLiu
Fixed some errors are thrown in a inner async callback which cannot b…
e71b413 
…e caught.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.988% when pulling 8c91aec on XiaoningLiu:2.10.3 into 0557d02 on Azure:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.988% when pulling 8c91aec on XiaoningLiu:2.10.3 into 0557d02 on Azure:master.

@coveralls
Copy link

coveralls commented Apr 12, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 91.988% when pulling 0d5c534 on XiaoningLiu:2.10.3 into 0557d02 on Azure:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.988% when pulling 8c91aec on XiaoningLiu:2.10.3 into 0557d02 on Azure:master.

jiacfan
jiacfan approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@jiacfan jiacfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vinjiang vinjiang merged commit 1e31548 into Azure:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacfan jiacfan jiacfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@XiaoningLiu @coveralls @jiacfan @vinjiang @dabutvin @cpwinn @MRayermannMSFT