Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise error for loop if Python 3.10 #261

Merged
merged 12 commits into from
Aug 10, 2021
Merged

raise error for loop if Python 3.10 #261

merged 12 commits into from
Aug 10, 2021

Conversation

swathipil
Copy link
Member

No description provided.

yunhaoling
yunhaoling reviewed Aug 3, 2021
View reviewed changes
uamqp/async_ops/_shared/utils.py Outdated Show resolved Hide resolved
uamqp/async_ops/client_async.py Show resolved Hide resolved
uamqp/async_ops/client_async.py Show resolved Hide resolved
uamqp/async_ops/client_async.py Outdated Show resolved Hide resolved
uamqp/async_ops/client_async.py Outdated Show resolved Hide resolved
uamqp/async_ops/receiver_async.py Show resolved Hide resolved
uamqp/async_ops/sender_async.py Show resolved Hide resolved
uamqp/async_ops/sender_async.py Outdated Show resolved Hide resolved
uamqp/async_ops/session_async.py Show resolved Hide resolved
uamqp/authentication/cbs_auth_async.py Show resolved Hide resolved
swathipil
swathipil commented Aug 5, 2021
View reviewed changes
tests/test_loop_param.py Outdated Show resolved Hide resolved
yunhaoling
yunhaoling reviewed Aug 5, 2021
View reviewed changes
uamqp/async_ops/utils.py Outdated Show resolved Hide resolved
yunhaoling
yunhaoling reviewed Aug 5, 2021
View reviewed changes
tests/test_loop_param.py Outdated Show resolved Hide resolved
@swathipil
Copy link
Member Author

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1034808&view=results

@yunhaoling
Copy link
Contributor

there're some missing loop property in certain classes?
but apart from that I think this looks great to me, thanks for the work!

making sure the livetest and CI pipeline get green before we merge the PR.

@swathipil
Copy link
Member Author

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1036740&view=results

@swathipil
Copy link
Member Author

CI: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1036739&view=results

yunhaoling
yunhaoling approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@swathipil
Copy link
Member Author

CI: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1039178&view=results
tests: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1039198&view=results

@swathipil swathipil merged commit 95ef0cb into Azure:master Aug 10, 2021
@swathipil swathipil deleted the remove-loop-param-3.10 branch August 10, 2021 16:52
This was referenced Aug 10, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swathipil @yunhaoling