[Cosmos DB] Handle cases where desired worker count exceeds int.MaxInt #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbatum
reviewed
Oct 24, 2023
|
|
||
| try | ||
| { | ||
| targetWorkerCount = (int)Math.Ceiling(remainingWork / (decimal)concurrency); |
There was a problem hiding this comment.
I suggest wrapping in a checked block - doing so makes sure that this operation will always throw an overflow exception regardless of the project level settings
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/statements/checked-and-unchecked
There was a problem hiding this comment.
done, updated all other SDK PRs to match this implementation
alrod
approved these changes
Oct 26, 2023
ealsur
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are updating TBS implementations in all extensions to ensure the requested TargetWorkerCount (int) does not overflow when an eventCount (long) / concurrency (int) exceeds int.MaxInt.
Related PRs