Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added WhatIf support to Test-ModuleLocally script + several smaller bugfixes #679

Merged
merged 58 commits into from
Nov 30, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 28, 2023

Description

@AlexanderSehr AlexanderSehr requested review from a team as code owners November 28, 2023 20:20
@AlexanderSehr AlexanderSehr self-assigned this Nov 28, 2023
@AlexanderSehr AlexanderSehr added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 28, 2023
@AlexanderSehr AlexanderSehr changed the title Users/alsehr/what if port feat: Added WhatIf support to Test-ModuleLocally script + several smaller bugfixes Nov 28, 2023
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 28, 2023 20:22
@ChrisSidebotham
Copy link
Contributor

@AlexanderSehr - Any reason why this is expecting a review from @Azure/avm-res-operationalinsights-workspace-module-owners-bicep?

@AlexanderSehr AlexanderSehr marked this pull request as draft November 29, 2023 08:01
auto-merge was automatically disabled November 29, 2023 08:01

Pull request was converted to draft

@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 29, 2023 08:01
@AlexanderSehr
Copy link
Contributor Author

AlexanderSehr commented Nov 29, 2023

@AlexanderSehr - Any reason why this is expecting a review from @Azure/avm-res-operationalinsights-workspace-module-owners-bicep?

Hey @ChrisSidebotham, not sure. I think I've seen in the log that Git was complaining about that module's encoding (-> Line-Ending) so maybe that's why. However, it's not part of the PR so it remains a bit odd. I wish I'd know :D

@ChrisSidebotham
Copy link
Contributor

@AlexanderSehr

        Alexander Sehr
        FTE - Any reason why this is expecting a review from @Azure/avm-res-operationalinsights-workspace-module-owners-bicep?

Hey @ChrisSidebotham Chris Sidebotham FTE, not sure. I think I've seen in the log that Git was complaining about that module's encoding (-> Line-Ending) so maybe that's why. However, it's not part of the PR so it remains a bit odd. I wish I'd know :D

I see there is now conflicts on this @AlexanderSehr

@ChrisSidebotham ChrisSidebotham added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Triage 🔍 Maintainers need to triage still labels Nov 29, 2023
@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr

        Alexander Sehr
        FTE - Any reason why this is expecting a review from @Azure/avm-res-operationalinsights-workspace-module-owners-bicep?

Hey @ChrisSidebotham Chris Sidebotham FTE, not sure. I think I've seen in the log that Git was complaining about that module's encoding (-> Line-Ending) so maybe that's why. However, it's not part of the PR so it remains a bit odd. I wish I'd know :D

I see there is now conflicts on this @AlexanderSehr

resolved. My fix in main was even more correct than this one :D

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Nov 29, 2023
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@eriqua eriqua marked this pull request as draft November 30, 2023 00:02
@eriqua eriqua marked this pull request as ready for review November 30, 2023 00:02
@AlexanderSehr AlexanderSehr merged commit 3a0f5a6 into Azure:main Nov 30, 2023
13 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/whatIfPort branch November 30, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants