Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/desktop-virtualization/host-pool #831

Merged
merged 62 commits into from
Feb 9, 2024

Conversation

moisesjgomez
Copy link
Contributor

@moisesjgomez moisesjgomez commented Jan 19, 2024

Description

Closes avm/res/desktop-virtualization/host-pool #144

avm.res.desktop-virtualization.host-pool

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

@moisesjgomez moisesjgomez requested a review from a team as a code owner January 19, 2024 01:35
@moisesjgomez
Copy link
Contributor Author

Updates have been made and badge up to date. @ChrisSidebotham One failure on PSRule due to secure parameter rule picking up term "key" on parameters even though they are not secrets.

@ChrisSidebotham
Copy link
Contributor

ChrisSidebotham commented Feb 6, 2024

Updates have been made and badge up to date. @ChrisSidebotham Chris Sidebotham FTE One failure on PSRule due to secure parameter rule picking up term "key" on parameters even though they are not secrets.

@BernieWhite - Looking into this issue we need a way to supress a rule for a single parameter, is this possible with the current release? As described above we have an issue in this workflow with 3 individual parameters in which are not actually secret values but being flagged as Should be marked as @secure due to the name containing secret and key and possibly token

@BernieWhite
Copy link

@ChrisSidebotham Yes you are able to configure AZURE_DEPLOYMENT_NONSENSITIVE_PARAMETER_NAMES as of v1.31.1 to ignore parameters by name.

https://azure.github.io/PSRule.Rules.Azure/setup/configuring-rules/#azure_deployment_nonsensitive_parameter_names

ChrisSidebotham
ChrisSidebotham previously approved these changes Feb 7, 2024
@ChrisSidebotham
Copy link
Contributor

@moisesjgomez - I see you indented secrets, this is not hte issue we need a new line (empty) at the bottom of the YAML file

@AlexanderSehr AlexanderSehr merged commit 52f99e3 into Azure:main Feb 9, 2024
9 checks passed
@moisesjgomez moisesjgomez deleted the host-pool branch July 18, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants