Linter perf improvement - cache LinterAnalyzer in BicepCompilationManager #5578
Conversation
|
Do you happen to have any data on the impact of the change? |
@majastrz, this - gets executed on every edit, which I think is wasteful. We have the ability to detect when there are changes in bicepconfig.json and we can use that to create a new version of LinterAnalyzer. I can measure how much time it takes to create the analyzer, but my guess is it's small. The overall impact depends on number of edits in the file.To answer your question, I don't have data in terms of perf test(I think this - #1641 needs to happen first). Let me know if we want to do some manual measurements. Edit: On edit(any key press event): |
bhsubra
force-pushed
the
dev/bhsubra/CacheLinterAnalyzerInBicepCompilationManager
branch
from
f11bee1
to
543bad6
Compare
Nice! |
| // We'll use default bicepconfig.json settings during SnippetsProvider creation to avoid errors during language service initialization. | ||
| // We don't do any validation in SnippetsProvider. So using default settings shouldn't be a problem. | ||
| Compilation compilation = new Compilation(namespaceProvider, sourceFileGrouping, configurationManager.GetBuiltInConfiguration(disableAnalyzers: true)); | ||
| Compilation compilation = new Compilation(namespaceProvider, sourceFileGrouping, configuration, linterAnalyzer); |
There was a problem hiding this comment.
@majastrz , no, we don't run linter rules. It uses the configuration with disabled analyzers:
There was a problem hiding this comment.
I will go ahead and merge this PR. I hope I answered your question. If there is any pending action item, I can take care of it in a follow up PR.
bhsubra
deleted the
dev/bhsubra/CacheLinterAnalyzerInBicepCompilationManager
branch
With current implementation, we create a new LinterAnalyzer on every text edit.
With changes in this PR, we will create a LinterAnalyzer on file open, cache it in BicepCompilationManager and reuse it. A new version of the LinterAnalyzer will be created whenever bicepconfig.json file is modified.