Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pipe & socket flags for language server startup #5852

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Support pipe & socket flags for language server startup #5852

merged 4 commits into from
Feb 3, 2022

Conversation

anthony-c-martin
Copy link
Member

No description provided.

majastrz
majastrz reviewed Feb 3, 2022
View reviewed changes
src/Bicep.LangServer.IntegrationTests/InputOutputTests.cs
new CancellationTokenSource(timeSpan).Token,
TestContext.CancellationTokenSource.Token).Token;

private static Process StartServerProcessWithConsoleIO()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StartServerProcessWithConsoleIO

All 3 versions of this differ only in the arguments. Worth refactoring?

majastrz
majastrz reviewed Feb 3, 2022
View reviewed changes
src/Bicep.LangServer.IntegrationTests/InputOutputTests.cs
FileName = "dotnet",
Arguments = $"{exePath} --pipe {pipeName}",
UseShellExecute = false,
RedirectStandardError = true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RedirectStandardError

If you don't have something to consume the stderr and stdout, you can get a deadlock. (Easiest is just to add dummy event handlers with the async redirection.)

majastrz
majastrz approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) February 3, 2022 02:48
@anthony-c-martin anthony-c-martin merged commit 1026291 into main Feb 3, 2022
@anthony-c-martin anthony-c-martin deleted the ant/pipes branch February 3, 2022 04:58
@anthony-c-martin anthony-c-martin mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-c-martin @majastrz