Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null 'name' property for resource to cause an error. #6348

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

davidcho23
Copy link
Contributor

@davidcho23 davidcho23 commented Mar 29, 2022

Fixes #5530

Change NameSyntax to TryGetNameSyntax() to avoid null exception being thrown when 'name' property is retrieved for the partially typed resource.

Added changes for both resource group and management group use cases.

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davidcho23 davidcho23 merged commit 9218c32 into main Mar 29, 2022
@davidcho23 davidcho23 deleted the davidcho23/fixPartiallyTypedResourceReference branch March 29, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request textDocument/codeAction failed. Failed to find a 'name' property for resource 'resourceGroup'
2 participants