-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spread test cases #247
Conversation
🦋 Changeset detectedLatest commit: db3d34e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add one more scenario: Spread an Alias which contains model as property?
model Thing {
@doc("name of the Thing")
name: string;
@doc("age of the Thing")
age: int32;
}
alias ThingAliasWithModel = {
@path id: string;
...Thing;
@header top: int32;
};
op spreadAliasWithModel( ...ThingAliasWithModel ): OKResponse;
@iscai-msft @timotheeguerin @weidongxu-microsoft Could you help review these cases? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java should have supported the spread. Not sure about .NET
""") | ||
@route("/alias/request-parameter/{id}") | ||
@put | ||
op spreadAliasAsRequestParameter(...AliasRequestParameter): OkResponse; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This scenario is ok, this is not a quantum model since this is an alias.
In spirit, should generate something like:
void spreadAliasAsRequestParameter(id: string, x_ms_test_header: string, name: string)
… discussion over them
Pls notice the case is not updated because the discussion is not finalized #247 (comment) I updated the comment and removed the cases with discussions over them. Pls help review again. |
Cadl Ranch Contribution Checklist:
@scenario
names. Someone can look at the list of scenarios and understand what I'm covering.@scenarioDoc
s for extra scenario description and to tell people how to pass my mock api check.