[Bug] Fix the issue that resume a call without internet would stop us…

…er from exit (#268)
Azure · Jun 16, 2022 · bbd06a9 · bbd06a9
1 parent 8142618
commit bbd06a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/...tionUICalling/AzureCommunicationUICalling/Redux/Middleware/CallingMiddlewareHandler.swift b/...tionUICalling/AzureCommunicationUICalling/Redux/Middleware/CallingMiddlewareHandler.swift
@@ -321,7 +321,9 @@ extension CallingMiddlewareHandler {
                         self.logger.debug("Subscription cancelled with Error Code: \(internalError)")
                         self.subscription.cancel()
                     }
-                } else if callingStatus == .disconnected {
+                // to fix the bug that resume call won't work without Internet
+                // we exit the UI library when we receive the wrong status .remoteHold
+                } else if callingStatus == .disconnected || callingStatus == .remoteHold {
                     self.logger.debug("Subscription cancel happy path")
                     dispatch(CompositeExitAction())
                     self.subscription.cancel()

diff --git a/AzureCommunicationUI/sdk/AzureCommunicationUICalling/CHANGELOG.md b/AzureCommunicationUI/sdk/AzureCommunicationUICalling/CHANGELOG.md
@@ -4,6 +4,7 @@
 ### Bugs Fixed
 - Fixed issue where header was still selectable with voiceover on and overlay visible. [#256](https://github.com/Azure/communication-ui-library-ios/pull/256)
 - Fixed hold overlay to have a solid colour. [#262](https://github.com/Azure/communication-ui-library-ios/pull/262) 
+- Fix the issue that resume a call without internet could stop user from exit. [#268](https://github.com/Azure/communication-ui-library-ios/pull/268
 
 ## 1.0.0-beta.2 (2022-06-13)
 ### New Features