Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Update PersonaData argument name #166

Merged
merged 2 commits into from
May 9, 2022
Merged

[Refactor] Update PersonaData argument name #166

merged 2 commits into from
May 9, 2022

Conversation

JoshuaLai
Copy link
Member

Purpose

As per conversation with Azure Review Board. Updating the argument to be more explicit dropping the _ in the parameters.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@JoshuaLai JoshuaLai requested review from a team as code owners May 9, 2022 21:13
@JoshuaLai JoshuaLai requested review from waynemo, palatter, AmyL219, jimchou-dev, kevinyulu and vhuseinova-msft and removed request for a team May 9, 2022 21:13
JoshuaLai
JoshuaLai commented May 9, 2022
View reviewed changes
.../AzureCommunicationUIDemoApp/AzureCommunicationUIDemoApp/Views/UIKitDemoViewController.swift
@@ -154,12 +155,16 @@ class UIKitDemoViewController: UIViewController {
? CustomColorTheming(envConfigSubject: envConfigSubject)
: Theming(envConfigSubject: envConfigSubject),
localization: localizationConfig)
let callComposite = CallComposite(withOptions: callCompositeOptions)
callComposite = CallComposite(withOptions: callCompositeOptions)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of how we need to set the remote participant avatar now we will need to inform developers to hold onto a reference to the CallComposite

@acs-ui-bot acs-ui-bot added the refactor For refactoring, dependency updates, or other code improvements intended for a future release. label May 9, 2022
palatter
palatter reviewed May 9, 2022
View reviewed changes
Copy link
Member

@palatter palatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JoshuaLai JoshuaLai merged commit 628c408 into feature/customdatamodel May 9, 2022
@JoshuaLai JoshuaLai deleted the refactor/personadatarename branch May 9, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palatter palatter palatter approved these changes

@kevinyulu kevinyulu kevinyulu approved these changes

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-ios-reviewer-1

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 was automatically assigned from Azure/acs-ui-ios-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev was automatically assigned from Azure/acs-ui-ios-reviewer-2

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft was automatically assigned from Azure/acs-ui-ios-reviewer-3

Assignees
No one assigned
Labels
refactor For refactoring, dependency updates, or other code improvements intended for a future release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoshuaLai @palatter @kevinyulu @acs-ui-bot