Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Display remote participants persona data in the grid view #171

Merged
merged 26 commits into from
May 12, 2022
Merged

[Feature] Display remote participants persona data in the grid view #171

merged 26 commits into from
May 12, 2022

Conversation

vhuseinova-msft
Copy link
Member

@vhuseinova-msft vhuseinova-msft commented May 9, 2022 •
edited
Loading

Purpose

  • Introduce functionality to set a remote participant persona data
  • Display avatars and updated names for remote participants (all data is saved and set locally)
  • Add an option for turning on remote persona data injection

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to test

Please turn on "Inject avatars" option in Settings

What to Check

Verify that the following are valid

  • images and name can be set for remote participants
  • preset image and name are shown for a participant who has identifier's last symbol in 0...5 range

Other Information

You may need to add a couple of users to the call to see avatars and updated names as some participants can have identifier's last symbol equal >5 or a letter.

@vhuseinova-msft
Added the event when remote participants joined a call
68c9d09
@vhuseinova-msft
Added RemoteParticipantsManager
0c41880
@vhuseinova-msft
Updated CallingSDKEventsHandling.
654eb19 
Added tests for CallingSDKEventsHandling
@vhuseinova-msft
Fixed comment
169f5f3
@vhuseinova-msft
Code review updates
34aea3f
@vhuseinova-msft
Renamed RemoteParticipantsManager
258621b
@vhuseinova-msft
Code review updates
56a31b9
@vhuseinova-msft
Code review updates
5b122c1
@vhuseinova-msft
Added a function for setting a remote participant's persona data
581a3a1
@vhuseinova-msft
Updated avatarStorage type
6337e72
@vhuseinova-msft
Added tests. Renamed AvatarViewManager
05d166c
@vhuseinova-msft
Merge branch 'feature/customdatamodel' of https://github.com/Azure/co…
f53a9c3 
…mmunication-ui-library-ios into task/remote-participants-custom-data-model-set

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUI.xcodeproj/project.pbxproj
#	AzureCommunicationUI/AzureCommunicationUI/CallComposite.swift
#	AzureCommunicationUI/AzureCommunicationUI/Presentation/Manager/AvatarViewManager.swift
#	AzureCommunicationUI/AzureCommunicationUITests/Manager/CompositeRemoteParticipantsManagerTests.swift
@vhuseinova-msft
Updated return type
ae1449f
@vhuseinova-msft
Updated setRemoteParticipantPersonaData func signature
8fc6d1f
@vhuseinova-msft
Merge branch 'feature/customdatamodel' of https://github.com/Azure/co…
a352c99 
…mmunication-ui-library-ios into task/remote-participants-custom-data-model-set

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUI/CallComposite.swift
#	AzureCommunicationUI/AzureCommunicationUI/DI/DependancyContainer.swift
#	AzureCommunicationUI/AzureCommunicationUI/Presentation/Factories/CompositeViewFactory.swift
#	AzureCommunicationUI/AzureCommunicationUI/Presentation/Manager/AvatarViewManager.swift
@vhuseinova-msft
Code review updates
5d9525b
@vhuseinova-msft
Added injection option for the demo app
e823ccd
@vhuseinova-msft
Added remote participants' persona data update
6836bc6
@vhuseinova-msft
Merge branch 'feature/customdatamodel' of https://github.com/Azure/co…
61410dd 
…mmunication-ui-library-ios into task/grid-update-remote-persona-data

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUI/CallComposite.swift
#	AzureCommunicationUI/AzureCommunicationUI/DI/DependancyContainer.swift
@vhuseinova-msft
Updated local and remote avatar injection
1422c27
@vhuseinova-msft
Merge branch 'feature/customdatamodel' of https://github.com/Azure/co…
41afe16 
…mmunication-ui-library-ios into task/grid-update-remote-persona-data

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUI/Presentation/SwiftUI/Calling/Grid/Cell/ParticipantGridCellViewModel.swift
@vhuseinova-msft
Merge branch 'feature/customdatamodel' of https://github.com/Azure/co…
bf02005 
…mmunication-ui-library-ios into task/grid-update-remote-persona-data

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUIDemoApp/AzureCommunicationUIDemoApp.xcodeproj/project.pbxproj
@vhuseinova-msft
Updated participants names
0e89ee9
@vhuseinova-msft vhuseinova-msft requested review from a team as code owners May 9, 2022 23:33
@vhuseinova-msft vhuseinova-msft changed the base branch from develop/beta to feature/customdatamodel May 9, 2022 23:33
@vhuseinova-msft
Updated useCustomRemoteParticipantsPersonaData default value
eaac125
@vhuseinova-msft
Merge branch 'feature/customdatamodel' of https://github.com/Azure/co…
4308f19 
…mmunication-ui-library-ios into task/grid-update-remote-persona-data

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUIDemoApp/AzureCommunicationUIDemoApp/Views/UIKitDemoViewController.swift
@acs-ui-bot acs-ui-bot added the task Task for completing a specific feature. label May 10, 2022
jimchou-dev
jimchou-dev approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@jimchou-dev jimchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@vhuseinova-msft vhuseinova-msft merged commit 4743c88 into feature/customdatamodel May 12, 2022
@vhuseinova-msft vhuseinova-msft deleted the task/grid-update-remote-persona-data branch May 12, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLai JoshuaLai JoshuaLai approved these changes

@jimchou-dev jimchou-dev jimchou-dev approved these changes

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-ios-reviewer-1

@palatter palatter Awaiting requested review from palatter palatter was automatically assigned from Azure/acs-ui-ios-reviewer-1

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 was automatically assigned from Azure/acs-ui-ios-reviewer-1

@kevinyulu kevinyulu Awaiting requested review from kevinyulu kevinyulu was automatically assigned from Azure/acs-ui-ios-reviewer-3

Assignees
No one assigned
Labels
task Task for completing a specific feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vhuseinova-msft @JoshuaLai @jimchou-dev @acs-ui-bot