Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Update the Manual Installation Instruction #208

Merged
merged 6 commits into from
Jun 1, 2022

Conversation

AmyL219
Copy link
Contributor

@AmyL219 AmyL219 commented May 24, 2022

Purpose

  • Update the Manual Installation Instruction for more detail and possible issues solution

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • You could follow the code and embed all dependencies manually.

@JoshuaLai
Copy link
Member

I don't think we want this PR to go directly into main. Lets discuss the strategy for this one, it is a lesson learned from last release about how the history goes out of sync

@AmyL219 AmyL219 changed the title [Doc] Update the Manual Installation Instruction [Documentation] Update the Manual Installation Instruction May 24, 2022
jimchou-dev
jimchou-dev previously approved these changes May 25, 2022
@AmyL219 AmyL219 dismissed stale reviews from jimchou-dev and vhuseinova-msft via 046ba59 May 27, 2022 17:32
jimchou-dev
jimchou-dev previously approved these changes May 27, 2022
kevinyulu
kevinyulu previously approved these changes May 27, 2022
@AmyL219
Copy link
Contributor Author

AmyL219 commented May 30, 2022

Could anyone have a brief test based on this instruction before I merge it? See if any part is not clear enough?

@vhuseinova-msft
Copy link
Member

Could anyone have a brief test based on this instruction before I merge it? See if any part is not clear enough?

@AmyL219 tested, added a couple of minor comments but otherwise looks good.

@AmyL219
Copy link
Contributor Author

AmyL219 commented May 31, 2022

Could anyone have a brief test based on this instruction before I merge it? See if any part is not clear enough?

@AmyL219 tested, added a couple of minor comments but otherwise looks good.

Thanks for testing. Updated the instruction!!

@AmyL219 AmyL219 merged commit 6f35a34 into main Jun 1, 2022
@AmyL219 AmyL219 deleted the doc/installInstru branch June 1, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants