New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Introduce new error event completion handler #212

Merged

vhuseinova-msft merged 15 commits into develop/beta from refactor/setparticipanterror

Jun 1, 2022

Member

JoshuaLai commented May 26, 2022

Purpose

Introduce a new error event completion handler.

Does this introduce a breaking change?

API is not yet public

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

JoshuaLai added 2 commits

May 25, 2022 17:07


          [CallComposite] adding new error handler in the set remoteparticipant…

fa588ea

…viewdata method


          [CallComposite] documentation update

cb4f5c2

acs-ui-bot added the refactor label

tjprescott reviewed

View reviewed changes

...municationUICalling/AzureCommunicationUICalling/Presentation/Manager/AvatarViewManager.swift Outdated Show resolved Hide resolved

...municationUICalling/AzureCommunicationUICalling/Presentation/Manager/AvatarViewManager.swift Outdated Show resolved Hide resolved

vhuseinova-msft added 3 commits

May 26, 2022 14:19


          Error handling update for AvatarViewManager

da9c945


          Updated setRemoteParticipantViewData function

0d82139


          Fixed RemoteParticipantAvatarHelper

7454c3e

tjprescott reviewed

View reviewed changes

.../AzureCommunicationUIDemoApp/AzureCommunicationUIDemoApp/RemoteParticipantAvatarHelper.swift Outdated Show resolved Hide resolved

tjprescott reviewed

View reviewed changes

...municationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/CallComposite.swift Outdated Show resolved Hide resolved

tjprescott reviewed

View reviewed changes

...municationUICalling/AzureCommunicationUICalling/Presentation/Manager/AvatarViewManager.swift Outdated Show resolved Hide resolved

tjprescott reviewed

View reviewed changes

...municationUICalling/AzureCommunicationUICalling/Presentation/Manager/AvatarViewManager.swift Outdated Show resolved Hide resolved

vhuseinova-msft added 3 commits

May 27, 2022 11:32


          Renamed function to set remote participant's view data

3a96957


          Updated setting remote participant view data functionality

a978be7


          Merge branch 'develop/beta' of https://github.com/Azure/communication…

58fde70

…-ui-library-ios into refactor/setparticipanterror

vhuseinova-msft marked this pull request as ready for review

May 30, 2022 17:05

vhuseinova-msft requested review from a team as code owners

May 30, 2022 17:05

vhuseinova-msft requested review from waynemo, palatter, AmyL219, jimchou-dev, kevinyulu and vhuseinova-msft

May 30, 2022 17:05


          Merge branch 'develop/beta' of https://github.com/Azure/communication…

f40fc50

…-ui-library-ios into refactor/setparticipanterror

tjprescott reviewed

View reviewed changes

...onUICalling/AzureCommunicationUICalling/CallCompositeOptions/CommunicationUIErrorEvent.swift Outdated Show resolved Hide resolved

...municationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/CallComposite.swift Show resolved Hide resolved

...municationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/CallComposite.swift Outdated Show resolved Hide resolved

waynemo previously requested changes

View reviewed changes

...UICalling/AzureCommunicationUICalling/CallCompositeOptions/ParticipantViewDataSetError.swift Outdated Show resolved Hide resolved

vhuseinova-msft added 2 commits

May 31, 2022 09:54


          Code review fixes

3407a60


          Merge branch 'develop/beta' of https://github.com/Azure/communication…

ed791cf

…-ui-library-ios into refactor/setparticipanterror

# Conflicts:
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/CallComposite.swift
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/CallCompositeOptions/CallCompositeErrorEvent.swift
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/Presentation/Manager/AvatarViewManager.swift

AmyL219 reviewed

View reviewed changes

...municationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/CallComposite.swift Outdated Show resolved Hide resolved


          Renamed ParticipantViewDataSetError to SetParticipantViewDataError

fd5bf62

jimchou-dev previously approved these changes

View reviewed changes

...UICalling/AzureCommunicationUICalling/CallCompositeOptions/ParticipantViewDataSetError.swift Outdated Show resolved Hide resolved


          Merge branch 'develop/beta' of https://github.com/Azure/communication…

e8d3b1c

…-ui-library-ios into refactor/setparticipanterror

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUIDemoApp/AzureCommunicationUIDemoApp/Views/SwiftUIDemoView.swift
#	AzureCommunicationUI/AzureCommunicationUIDemoApp/AzureCommunicationUIDemoApp/Views/UIKitDemoViewController.swift
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling.xcodeproj/project.pbxproj
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/DI/DependancyContainer.swift
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICallingTests/DI/DependencyContainerTests.swift
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICallingTests/Manager/AvatarManagerTests.swift

vhuseinova-msft dismissed jimchou-dev’s stale review via

e8d3b1c

June 1, 2022 18:34


          Code review fixes

41ee83b

jimchou-dev approved these changes

View reviewed changes

waynemo dismissed their stale review

June 1, 2022 21:02

Others to review after latest changes.

AmyL219 approved these changes

View reviewed changes


          Merge branch 'develop/beta' of https://github.com/Azure/communication…

bf3625d

…-ui-library-ios into refactor/setparticipanterror

vhuseinova-msft merged commit 6e59791 into develop/beta

vhuseinova-msft deleted the refactor/setparticipanterror branch

June 1, 2022 23:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tjprescott tjprescott left review comments

AmyL219 AmyL219 approved these changes

jimchou-dev jimchou-dev approved these changes

waynemo waynemo left review comments

palatter Awaiting requested review from palatter palatter was automatically assigned from Azure/acs-ui-ios-reviewer-1

kevinyulu Awaiting requested review from kevinyulu kevinyulu was automatically assigned from Azure/acs-ui-ios-reviewer-3

vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft was automatically assigned from Azure/acs-ui-ios-reviewer-3

Labels