Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Refactor launch function and RemoteOptions #229

Merged
merged 6 commits into from
Jun 2, 2022
Merged

[Refactor] Refactor launch function and RemoteOptions #229

merged 6 commits into from
Jun 2, 2022

Conversation

jimchou-dev
Copy link
Member

Purpose

  • Refactor launch function
  • Refactor RemoteOptions to replace GroupCallOptions and TeamsMeetingOptions
  • Introduce CallCompositeLocator enum, may be renamed in separate PR
  • Documentation/Changelog update will be in separate PR

Does this introduce a breaking change?

[ x ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What to Check

Verify that the following are valid

  • All unit test and UI test are passing, app is functional

Other Information

@jimchou-dev jimchou-dev requested review from a team as code owners June 1, 2022 18:28
@acs-ui-bot acs-ui-bot added the refactor For refactoring, dependency updates, or other code improvements intended for a future release. label Jun 1, 2022
kevinyulu
kevinyulu previously approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@kevinyulu kevinyulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with iPhone XR, looks good.

...eCommunicationUICalling/AzureCommunicationUICalling/CallCompositeOptions/RemoteOptions.swift Outdated Show resolved Hide resolved
...tionUICalling/AzureCommunicationUICallingTests/CallCompositeOptions/RemoteOptionsTests.swift Show resolved Hide resolved
kevinyulu
kevinyulu previously approved these changes Jun 1, 2022
View reviewed changes
@jimchou-dev jimchou-dev merged commit 4ee495c into develop/beta Jun 2, 2022
@jimchou-dev jimchou-dev deleted the refactor/launch branch June 2, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palatter palatter palatter approved these changes

@kevinyulu kevinyulu kevinyulu approved these changes

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-ios-reviewer-1

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 was automatically assigned from Azure/acs-ui-ios-reviewer-1

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai was automatically assigned from Azure/acs-ui-ios-reviewer-2

Assignees
No one assigned
Labels
refactor For refactoring, dependency updates, or other code improvements intended for a future release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimchou-dev @palatter @kevinyulu @vhuseinova-msft @acs-ui-bot