Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Accessibility hold overlay should be solid colour #262

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

JoshuaLai
Copy link
Member

Purpose

As per figma:
Screen Shot 2022-06-15 at 3 00 40 PM
The hold overlay should have a solid colour and not have the same background colour like the lobby overlay.
Introducing new way to set background via the protocol

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@JoshuaLai JoshuaLai requested review from a team as code owners June 15, 2022 19:19
@JoshuaLai JoshuaLai changed the base branch from main to develop/beta June 15, 2022 19:19
@acs-ui-bot acs-ui-bot added the bug Something isn't working label Jun 15, 2022
Copy link
Contributor

@AmyL219 AmyL219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. But
Does accessibility team mention why onLobby view could be transparent?
Does this also need to be applied in Android design
Does Alex know the update?

@JoshuaLai
Copy link
Member Author

JoshuaLai commented Jun 15, 2022

Approve. But Does accessibility team mention why onLobby view could be transparent?

Thats a good point we will need to bring up with the Accessibility team

Does this also need to be applied in Android design

Let me chat with them to make sure. This design is actually what was originally intended and in figma

Does Alex know the update?

Yes, he was the one that called this out, this is as per figma design.

Copy link
Member

@palatter palatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JoshuaLai JoshuaLai merged commit 11c44f9 into develop/beta Jun 15, 2022
@JoshuaLai JoshuaLai deleted the bug/callhold_accessibility branch June 15, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants