Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Add delay for camera status update #270

Merged

Conversation

vhuseinova-msft
Copy link
Member

Purpose

  • Added delay for camera switching and for turning camera on
  • Updated Changelog

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

  • turn on-of camera quickly a couple of times, a local camera video should be shown as expected
  • switch between back and front camera quickly a couple of times, a local camera video should be shown as expected

@vhuseinova-msft vhuseinova-msft marked this pull request as draft June 16, 2022 23:31
@vhuseinova-msft vhuseinova-msft marked this pull request as ready for review June 16, 2022 23:51
@acs-ui-bot acs-ui-bot added the refactor For refactoring, dependency updates, or other code improvements intended for a future release. label Jun 17, 2022
@vhuseinova-msft vhuseinova-msft merged commit d7ff79b into develop/beta Jun 17, 2022
@vhuseinova-msft vhuseinova-msft deleted the refactor/prevent-quick-switch-control-buttons branch June 17, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor For refactoring, dependency updates, or other code improvements intended for a future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants