Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Not trigger CameraPreviewOnTriggered when have internal error #273

Merged
merged 3 commits into from
Jun 20, 2022
Merged

[Bugfix] Not trigger CameraPreviewOnTriggered when have internal error #273

merged 3 commits into from
Jun 20, 2022

Conversation

jimchou-dev
Copy link
Member

Purpose

  • Not trigger CameraPreviewOnTriggered when have internal error when going back to setupView

Does this introduce a breaking change?

[ ] Yes
[ x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What to Check

Verify that the following are valid

  • When callEvicted or callDenied, or other internal error will have same camera state when going back to setupView
  • eg. Test if camera is on in a call, camera in setupView will remain on when being evicted
  • eg. Test if camera is off in a call, camera in setupView will remain off when being evicted

Other Information

@jimchou-dev jimchou-dev requested review from a team as code owners June 20, 2022 18:25
JoshuaLai
JoshuaLai previously approved these changes Jun 20, 2022
View reviewed changes
vhuseinova-msft
vhuseinova-msft approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@vhuseinova-msft vhuseinova-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested

@acs-ui-bot acs-ui-bot added the bug Something isn't working label Jun 20, 2022
@jimchou-dev jimchou-dev merged commit aa0bd6c into release/AzureCommunicationUICalling_1.0.0 Jun 20, 2022
@jimchou-dev jimchou-dev deleted the bug/setupView-camera-state-internal-error branch June 20, 2022 19:02
JoshuaLai pushed a commit that referenced this pull request Jun 20, 2022
@jimchou-dev @JoshuaLai
[Bugfix] Not trigger CameraPreviewOnTriggered when have internal error (
132f884 
#273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLai JoshuaLai JoshuaLai approved these changes

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-ios-reviewer-1

@palatter palatter Awaiting requested review from palatter palatter was automatically assigned from Azure/acs-ui-ios-reviewer-1

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 was automatically assigned from Azure/acs-ui-ios-reviewer-1

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac was automatically assigned from Azure/acs-ui-ios-reviewer-2

@kevinyulu kevinyulu Awaiting requested review from kevinyulu kevinyulu was automatically assigned from Azure/acs-ui-ios-reviewer-3

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimchou-dev @JoshuaLai @vhuseinova-msft @acs-ui-bot