-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Alert When Network Lost #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeng-ms
changed the title
[Feature] add alert when network lost
[Feature] Add Alert When Network Lost
Aug 30, 2022
jpeng-ms
requested review from
AmyL219,
emlynmac,
JoshuaLai,
kevinyulu,
vhuseinova-msft,
Leah-Xia-Microsoft and
jimchou-dev
August 30, 2022 18:47
kevinyulu
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on device LGTM
vhuseinova-msft
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The goal is to alert Contoso user they cannot join the call if their internet is down.
Technical details
This PR introduces a network manager which listens to system event on network condition.
Setupviewmodel would be responsible to dispatch error actions to update network state, which would be used by error banner view accordingly.
The overall flow is the following:
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Other Information
Expected Behaviour
Screenshots
SDK error when network is offline (without tapping on join call):
SDK error when network is offline (after tapping on join call):
UI: