Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Info Header Font Size Fix #331

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

jpeng-ms
Copy link
Member

@jpeng-ms jpeng-ms commented Sep 2, 2022

Purpose

A11y wanted the info header to support large font size.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  1. open app in simulator
  2. go to settings
  3. go to accessibility
  4. enable large font
  5. go back to app, join a call

What to Check

  1. text not getting cutoff
  2. text does appear bigger when a11y is enabled

Other Information

before and after:
image

Scale down test

longest text in info header currently:
image
image
image

@jpeng-ms jpeng-ms marked this pull request as ready for review September 2, 2022 01:25
@jpeng-ms jpeng-ms requested review from a team as code owners September 2, 2022 01:25
@acs-ui-bot acs-ui-bot added the bug Something isn't working label Sep 2, 2022
@jpeng-ms jpeng-ms requested review from jimchou-dev and Leah-Xia-Microsoft and removed request for kevinyulu September 2, 2022 16:08
Copy link
Member

@Leah-Xia-Microsoft Leah-Xia-Microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@palatter palatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jpeng-ms jpeng-ms merged commit b0a1078 into develop Sep 7, 2022
@jpeng-ms jpeng-ms deleted the bug/info-header-font-size-fix branch September 7, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants