-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] add a aad token for getting the acs token in joining a call #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinyulu
requested review from
waynemo,
palatter,
AmyL219,
emlynmac,
jimchou-dev,
vhuseinova-msft and
Leah-Xia-Microsoft
October 5, 2022 17:01
kevinyulu
changed the title
add a aad token for getting the acs token in joining a call
[Task] add a aad token for getting the acs token in joining a call
Oct 5, 2022
emlynmac
previously approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vhuseinova-msft
previously approved these changes
Oct 6, 2022
jimchou-dev
previously approved these changes
Oct 7, 2022
palatter
reviewed
Oct 12, 2022
AzureCommunicationUI/AzureCommunicationUIDemoApp/Sources/AuthenticationHelper.swift
Show resolved
Hide resolved
…#386) * (WIP) add switching to token url in the ui test * use token url and token alternatively to test the join call * refactor on token selection in uitest Co-authored-by: Kevin Guo <v-kevinguo@microsoft.com>
kevinyulu
dismissed stale reviews from jimchou-dev, vhuseinova-msft, and emlynmac
via
October 12, 2022 22:38
1688772
kevinyulu
requested review from
palatter,
jpeng-ms,
emlynmac,
jimchou-dev and
vhuseinova-msft
October 12, 2022 22:45
vhuseinova-msft
approved these changes
Oct 12, 2022
jpeng-ms
approved these changes
Oct 12, 2022
palatter
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information