Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] add a aad token for getting the acs token in joining a call #380

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

kevinyulu
Copy link
Contributor

Purpose

  • Adding a new environment config property aadToken to be used to sent as a header in getting an ACS Token

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
  • provide a valid AAD token and ACS Token Url, and Launch the app
  • join any call.

What to Check

Verify that the following are valid

  • try to see if you can join a call with a valid input above
  • try to see if you see an error when joining a call, if you provide an invalid aad token or do not provide aad token

Other Information

@kevinyulu kevinyulu requested review from a team as code owners October 5, 2022 17:01
@kevinyulu kevinyulu changed the title add a aad token for getting the acs token in joining a call [Task] add a aad token for getting the acs token in joining a call Oct 5, 2022
@kevinyulu kevinyulu added the task Task for completing a specific feature. label Oct 5, 2022
emlynmac
emlynmac previously approved these changes Oct 6, 2022
Copy link
Member

@emlynmac emlynmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vhuseinova-msft
vhuseinova-msft previously approved these changes Oct 6, 2022
jimchou-dev
jimchou-dev previously approved these changes Oct 7, 2022
kevinyulu and others added 2 commits October 12, 2022 15:22
…#386)

* (WIP) add switching to token url in the ui test

* use token url and token alternatively to test the join call

* refactor on token selection in uitest

Co-authored-by: Kevin Guo <v-kevinguo@microsoft.com>
@kevinyulu kevinyulu merged commit 38d542d into develop Oct 13, 2022
@kevinyulu kevinyulu deleted the task/e2eAADToken branch October 13, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task for completing a specific feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants