Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Resolved Call on Hold video issue #414

Conversation

palatter
Copy link
Member

…en resuming.

Purpose

  • Fixed issue with call on hold video not showing up for remote user wh…

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
  1. Join a call
  2. Turn on video
  3. Background tha app and start "Ask Siri"
  4. Return to the app
  5. Resume call

Actual result: the video is off
Expected result: the video is on

What to Check

Verify that the following are valid

  • ...

Other Information

@jpeng-ms
Copy link
Member

jpeng-ms commented Oct 26, 2022

tested on iPhone 11 for following two cases and it's working as expected:

  • call on hold with camera on
  • put app to background with camera on

@palatter palatter merged commit c7a8408 into release/AzureCommunicationUICalling_1.1.0 Oct 26, 2022
@palatter palatter deleted the bug/call-on-hold-video-issue-2 branch October 26, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants