Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Work around for failure to grab ownership of microphone on first try. #423

Conversation

palatter
Copy link
Member

@palatter palatter commented Nov 2, 2022

Purpose

  • Work around for failure to grab ownership of microphone on the first try.

Open ACS UI Lib Demo and join a group call, end the call successfully
Open a music/podcast/audio app and play something
Stop playing the audio
Open the composite again
Join call
The microphone will not work despite being unmuted

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@vhuseinova-msft
Copy link
Member

vhuseinova-msft commented Nov 3, 2022

@palatter The issue is still reproducible, the microphone doesn't work even when I'm unmuted for the joined call (at the last step). But after I rejoin the same call again, microphone works as expected

@palatter
Copy link
Member Author

palatter commented Nov 3, 2022

@palatter The issue is still reproducible, the microphone doesn't work even when I'm unmuted for the joined call (at the last step). But after I rejoin the same call again, microphone works as expected
@vhuseinova-msft
My mistake, I missed one line. Should be fixed now.

Copy link
Member

@vhuseinova-msft vhuseinova-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested!

@palatter palatter merged commit 98c6d61 into release/AzureCommunicationUICalling_1.1.0 Nov 3, 2022
@palatter palatter deleted the bug/microphone-priority-issue branch November 3, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants