Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calling][Bugfix] Initial switch to speaker fails, causing the audio device drawer to not populate #893

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

ahammer
Copy link
Member

@ahammer ahammer commented Jun 20, 2024

Purpose

  • State gets stuck in "requesting" mode, which prevents the VM from populating the list. Dispatch additional action on error for "audioDeviceChangeSucceeded", with the currently detected device, to set the state back into the proper mode.

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Pull request checklist

This PR has considered:

  • Color Theming
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • View Data Injection
  • Demo App UI/UX update

How to Test

  • Open...
  • Click on...

What to Check

Before After
Screenshot or description before this change Screenshot or description with this change

Other Information

@iaulakh iaulakh merged commit a40a227 into release/calling-1.8.0 Jun 20, 2024
5 checks passed
@iaulakh iaulakh deleted the bugfix/drawer_not_populating branch June 20, 2024 16:23
iaulakh pushed a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants