Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storybook to enable noImplicitAny use #4206

Merged
merged 12 commits into from
Mar 4, 2024

Conversation

edwardlee-msft
Copy link
Contributor

What

Storybook snippets to enable noImplictAny use.

Important notes found in this PR:

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Calling bundle size is increased❗.

  • Current size: 4973999
  • Base size: 4973946
  • Diff size: 53

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Chat bundle size is not changed.

  • Current size: 1457868
  • Base size: 1457868
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Mar 1, 2024

CallWithChat bundle size is increased❗.

  • Current size: 5705482
  • Base size: 5705429
  • Diff size: 53

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Copy link
Contributor

github-actions bot commented Mar 1, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 47083 / 76175
61.8%
47083 / 76175
61.8%
956 / 2137
44.73%
2713 / 4453
60.92%
Current 47043 / 76177
61.75%
47043 / 76177
61.75%
956 / 2137
44.73%
2693 / 4442
60.62%
Diff -40 / 2
-0.05%
-40 / 2
-0.05%
0 / 0
0%
-20 / -11
-0.3%

Copy link
Contributor

github-actions bot commented Mar 1, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 47060 / 76175
61.77%
47060 / 76175
61.77%
956 / 2137
44.73%
2700 / 4443
60.76%
Current 47128 / 76177
61.86%
47128 / 76177
61.86%
956 / 2137
44.73%
2725 / 4466
61.01%
Diff 68 / 2
0.09%
68 / 2
0.09%
0 / 0
0%
25 / 23
0.25%

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Copy link
Member

@emlynmac emlynmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep an eye on the upstream TS issue and if that gets resolved, update ours.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Copy link
Contributor

github-actions bot commented Mar 4, 2024

@edwardlee-msft edwardlee-msft enabled auto-merge (squash) March 4, 2024 17:00
@edwardlee-msft edwardlee-msft merged commit e4393b9 into main Mar 4, 2024
37 checks passed
@edwardlee-msft edwardlee-msft deleted the elee/storybook-snippets-noImplicitAny branch March 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants