Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename from ESA to DMA #108

Merged
merged 10 commits into from
Dec 13, 2021
Merged

Rename from ESA to DMA #108

merged 10 commits into from
Dec 13, 2021

Conversation

esbran
Copy link
Contributor

@esbran esbran commented Nov 30, 2021

This PR fixes

Renaming from ESA to DMA
Minor typos

@esbran esbran requested a review from a team as a code owner November 30, 2021 10:13
@esbran esbran added the documentation Improvements or additions to documentation label Nov 30, 2021
@esbran esbran linked an issue Nov 30, 2021 that may be closed by this pull request
Name change #107
Closed
amanjeetsingh
amanjeetsingh reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change.

Clarification - is it "Deploy Data Management & Analytics Scenario" or "Deploy Data Management & Analytics scenario" ?
Why is the word scenario in uppercase? Please ignore my comment if it has to be in uppercase. Thanks.

@marvinbuss marvinbuss marked this pull request as draft December 6, 2021 07:15
@marvinbuss
Copy link
Collaborator

Minor change.

Clarification - is it "Deploy Data Management & Analytics Scenario" or "Deploy Data Management & Analytics scenario" ? Why is the word scenario in uppercase? Please ignore my comment if it has to be in uppercase. Thanks.

Good question. Let's clarify and make sure it is consistent across all repos. 👍

@marvinbuss marvinbuss added this to the v1.2.0 milestone Dec 6, 2021
@marvinbuss marvinbuss added the committed Committed item label Dec 6, 2021
marvinbuss
marvinbuss approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Will merge after getting the other repos ready.

@marvinbuss marvinbuss marked this pull request as ready for review December 13, 2021 08:57
@marvinbuss marvinbuss merged commit 90a42be into main Dec 13, 2021
@marvinbuss marvinbuss deleted the espen/renaming branch December 13, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanjeetsingh amanjeetsingh amanjeetsingh left review comments

@marvinbuss marvinbuss marvinbuss approved these changes

Assignees

@esbran esbran

Labels
committed Committed item documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Name change
3 participants
@esbran @marvinbuss @amanjeetsingh