Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Update README.md #170

Merged
merged 2 commits into from
Apr 5, 2017
Merged

Update README.md #170

merged 2 commits into from
Apr 5, 2017

Conversation

DBojsen
Copy link
Contributor

@DBojsen DBojsen commented Mar 19, 2017

Adding Proficy Historian module

Adding Proficy Historian module
@msftclas
Copy link

@DBojsen,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@damonbarry
Copy link
Member

@DBojsen This is great!

Looking at our Contribution Guidelines, one of the requirements for getting an OSS module featured is that you provide some level of automated tests, so users can validate that the module does what it says it does. Can you add some tests for this module?

At a basic level, you could add a single end-to-end test that passes if it can connect to a Proficy Historian server, receive some data from it, and publish the data to the gateway's Broker. Of course the user would have to supply the Proficy Historian server connection info (unless there's a way to mock the historian API).

You might have noticed that one of the modules we're already featuring is missing tests. 🤕 That's a problem we hope to correct.

Copy link
Contributor

@aribeironovaes aribeironovaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as Request change so tests can be added.

@DBojsen
Copy link
Contributor Author

DBojsen commented Apr 4, 2017

Hi Damon, Angelo

I have added unit tests as a separate project.

BR David

@aribeironovaes aribeironovaes merged commit 64ad04e into Azure:master Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants