Force failure #388
Closed
Force failure #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As azure/powershell@v1 now supports macOS, we need a new way to trigger a failure to show that ps steps can fail and their failings can be handled.
jsoref
had a problem deploying
to
Automation test
GitHub Actions
Failure
|
@jsoref, we're glad you ask this. This workflow file is for negative test cases. It's not for reading but marking all cases we're not supporting right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #385 (comment)
I'm not particularly fond of this fix. It depends on what the goal of this step was, and I can't really tell. I looked at the various steps that this workflow had and it seems to have evolved a number of times. The current construct seems pretty complicated for something that's just interested in the exit code of an action (which in turn is dependent on it not supporting the tested platform).
It could be simplified to just
exit 1instead of retaining the current commands (which previously were never run).