Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #459: Errors when registering cloud profile for AzureStack #466

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Fix #459: Errors when registering cloud profile for AzureStack #466

merged 2 commits into from
Jun 20, 2024

Conversation

MoChilia
Copy link
Member

  1. The argument for az cloud register doesn't escape correctly.
  2. Lack await keyword for registerAzurestackEnvIfNecessary.

Close #459

@MoChilia MoChilia requested a review from YanaXu June 20, 2024 03:16
@MoChilia MoChilia self-assigned this Jun 20, 2024
@MoChilia MoChilia mentioned this pull request Jun 20, 2024
Closed
@MoChilia MoChilia merged commit e1a0ade into master Jun 20, 2024
19 checks passed
@MoChilia MoChilia deleted the fix-459-azurestack branch June 20, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanaXu YanaXu YanaXu approved these changes

Assignees

@MoChilia MoChilia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login @v2 error registering cloud profile when used against AzureStack
2 participants
@MoChilia @YanaXu