Remove cookie support. #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astegmaier
requested review from
jeremymeng,
xirzec and
deyaaeldeen
as code owners
xirzec
requested changes
Jul 6, 2023
There was a problem hiding this comment.
@astegmaier can you bump the version in
ms-rest-js/lib/util/constants.ts
Line 10 in 3b57cdf
package.json, and add a Changelog.md entry?
That should be all that is needed to make the CI happy and allow us to release.
Done. |
|
@astegmaier 2.7.0 should be live now https://www.npmjs.com/package/@azure/ms-rest-js/v/2.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #483 and supersedes PR #484. There is a security vulnerability in the
tough-cookiepackage for versions<4.3.1- see https://nvd.nist.gov/vuln/detail/CVE-2023-26136. Previously@azure/ms-rest-jsdepended on^3.0.0, which lockedtough-cookieto an unsecure version.After discussion with @xirzec, we concluded the right resolution was to remove the dependency entirely, similar to what was done in azure-sdk-for-js PR 24660, which was the model for this PR.
Testing
Build (
npm run build) and tests (npm run test) continue to succeed with this upgrade.