Skip to content
This repository has been archived by the owner on Jul 6, 2022. It is now read-only.

Add VNET rules to PostgreSQL #676

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Add VNET rules to PostgreSQL #676

merged 2 commits into from
Feb 18, 2019

Conversation

timja
Copy link
Contributor

@timja timja commented Feb 17, 2019

Closes #667

Manually tested:

  • azure-postgresql-10-dbms
  • azure-postgresql-10

Added life cycle test coverage as well

@timja
Copy link
Contributor Author

timja commented Feb 17, 2019

Is it expected that lint should take greater than 10 minutes locally?

$ docker ps
CONTAINER ID        IMAGE                                       COMMAND                  CREATED             STATUS              PORTS                    NAMES
18c8f9e10e0e        quay.io/deis/lightweight-docker-go:v0.2.0   "gometalinter ./... …"   11 minutes ago      Up 11 minutes                                sad_almeida

Tests etc executed at a reasonable speed for me, but lint was ridiculous, I thought it wasn't working so kept cancelling it

@zhongyi-zhang
Copy link
Contributor

Not expected to be so long. I kicked off the CI. The lint test result looks good. Again thanks for the contribution! I'll look into the code change later.

zhongyi-zhang
zhongyi-zhang reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@zhongyi-zhang zhongyi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM. CI passed, too. Only two quite small problems.

pkg/services/postgresql/plan_schemas.go Outdated Show resolved Hide resolved
pkg/services/postgresql/dbms_arm_template.go Outdated Show resolved Hide resolved
zhongyi-zhang
zhongyi-zhang approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@zhongyi-zhang zhongyi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since the new commitment doesn't impact code path or any execution result, will merge without another CI build.

@zhongyi-zhang zhongyi-zhang merged commit 4797e90 into Azure:master Feb 18, 2019
@timja timja deleted the feature/add-vnet-rules-to-postgres branch February 18, 2019 16:57
@zhongyi-zhang zhongyi-zhang added this to the v1.5.0 milestone Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhongyi-zhang zhongyi-zhang zhongyi-zhang approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@krancour krancour Awaiting requested review from krancour

@norshtein norshtein Awaiting requested review from norshtein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timja @zhongyi-zhang