This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 72
Fix device insert reducer function so the id in the items list is a s… #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring (not an array)
isaac-dasan
approved these changes
Sep 27, 2018
3 tasks
isaac-dasan
added a commit
that referenced
this pull request
Oct 16, 2018
* Add scaffolding for packages page (#1063) * pakages tab * Packages Folder * Reusable Header Components * package svg * fix for mary ellen's comments * Fix for Stephen's comments * README update 1 * oneProperty declarations * Fix 2 for MaryEllen's comments * 8/8 EOD commit * 8/9 SOD * configModels * isaac-d-t * 8 13 localhost * remove package title and header * complete reducer * crazy translation error * scafolding bug fixes * Revert "8 13 localhost" This reverts commit 9de75d0. * readme merge * fix for mary ellen's cooments 1 * remove css from svg * removing warnings * copy right and spacing * work in progress * Display content in packages grid (#1068) * pakages tab * Packages Folder * Reusable Header Components * package svg * fix for mary ellen's comments * Fix for Stephen's comments * README update 1 * oneProperty declarations * Fix 2 for MaryEllen's comments * 8/8 EOD commit * 8/9 SOD * configModels * isaac-d-t * 8 13 localhost * remove package title and header * complete reducer * crazy translation error * scafolding bug fixes * Revert "8 13 localhost" This reverts commit 9de75d0. * readme merge * Revert "Revert "8 13 localhost"" This reverts commit 2b42e8c. * fix for mary ellen's cooments 1 * remove css from svg * removing warnings * packagesColumnDefs * copy right and spacing * work in progress * Display data in grid * reset app.config * fix for mary ellen's comments * Merge Master into Edge Feature Branch (#1073) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Add newPackage Flyout (#1070) * newPackage commit 1 * onChange * upload successful * add new package to grid * newPackage complete * alignment * remove color inside theme * combine * .new-package-header combine * error message * single delete * Delete package (#1076) * newPackage commit 1 * onChange * upload successful * add new package to grid * newPackage complete * alignment * remove color inside theme * combine * .new-package-header combine * error message * single delete * deletePackage commit 1 * deletePackage commit 2 * delete commit 3 * delete commit 4 * README.md * ME's review comments fix * Fix for Elvin's Comments * fix for stephen's comments * Merge Master into Edge feature branch (#1083) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * example * add packages * Deployments page scaffolding (#1088) * Merge Master into Edge Feature Branch to keep it up to date (#1091) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * Rename Package Flyouts to be consistent with rest of UI (#1087) * Rename Package Flyouts to be consistent with rest of UI * rename path * Add glimmer icon to newly added grid items (#1095) * Add glimmer icon to newly added grid items * Add new Deployment (#1096) * Add new Deployment * Fix for ME's review coments * DevicesByCondition * undefined * Fix for ME's 2nd comments * alphabetical order * Merge Master into Edge Feature Branch (#1100) * Merge Master into Feature branch for Edge * nits * Add glimmer icon for newly added deployments (#1101) * More context bar arrangement; also page titles (#1104) * More context bar arrangement; also page titles * format per vscode auto formatting * implement new ComponentArray and change existing code to use it (#1108) * Followup to remove more keys for ComponentArray usage (#1109) * Merge Master with Feature Branch (#1111) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * rearrange controls on context menus (#1093) * Add links to Time Series Insights from Dashboard and Device Details Page (#1085) Add a Hyperlink shared component Fetch the Time Series Explorer URL from Telemetry Add link to dashboard and device details * Adding curly brackets in json Payload (#1094) * Fix alignment of stats on dashbaord (quick fix) (#1097) * Move Add Condition button below the rule conditions (#1103) * Update section decriptions to be more actionable on Device Details (#1110) * Fix device insert reducer function so the id in the items list is a string (not an array) (#1114) * Adding Deployment Details Page (#1112) * Squash DeploymentDetails commits * initial review fixes * review comments fix part 2 * fix for Stephen's review comments * adding test page and minor fixes * ByQuery * fix deployments tests * Delete Modal for Packages and Deployments Page (#1115) * delete Packages and delete Deployments * remove deleteDeployment.container * remove componentArray from deploymentDetailsGrid * remove payload * onrowclicked and softselected for deviceDetails * remove comment * id = '' * Adding Deployment message details formatting and removing onRowClick (#1117) * Deployment message details formatting and removing onRowClick * fix for stephen's comments * minimize setState calls * refactoring componentWillReceiveProps * semicolon and single line * Replacing ids with Names and removing IOThubmanager's dependency on c… (#1120) * replacing ids with Names and removing IOThubmanager's dependency on config service * type * Adding In-porduct telemetry for Packages and Deployments (#1122) * Adding In-porduct telemetry for Packages and Deployments * remove unused model * Styling update (#1124) * Styling update * red * * new line * Merge master into Edge Feature branch (#1125) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * rearrange controls on context menus (#1093) * Add links to Time Series Insights from Dashboard and Device Details Page (#1085) Add a Hyperlink shared component Fetch the Time Series Explorer URL from Telemetry Add link to dashboard and device details * Adding curly brackets in json Payload (#1094) * Fix alignment of stats on dashbaord (quick fix) (#1097) * Move Add Condition button below the rule conditions (#1103) * Update section decriptions to be more actionable on Device Details (#1110) * fix shell.test.js (#1116) * unit Test fix * entities length > 0 * Fix for bugBash bugs (#1130) # Conflicts: # src/store/reducers/deploymentsReducer.js * keyboard accessibility fix (#1131)
molly-moen
pushed a commit
that referenced
this pull request
Nov 5, 2018
* Add tags to embed snippets in docs (#1123) * Add tags to basic page * Add tags for doc embedding * npm audit fix (#1121) * Merge Edge Feature Branch into Master (#1127) * Add scaffolding for packages page (#1063) * pakages tab * Packages Folder * Reusable Header Components * package svg * fix for mary ellen's comments * Fix for Stephen's comments * README update 1 * oneProperty declarations * Fix 2 for MaryEllen's comments * 8/8 EOD commit * 8/9 SOD * configModels * isaac-d-t * 8 13 localhost * remove package title and header * complete reducer * crazy translation error * scafolding bug fixes * Revert "8 13 localhost" This reverts commit 9de75d0. * readme merge * fix for mary ellen's cooments 1 * remove css from svg * removing warnings * copy right and spacing * work in progress * Display content in packages grid (#1068) * pakages tab * Packages Folder * Reusable Header Components * package svg * fix for mary ellen's comments * Fix for Stephen's comments * README update 1 * oneProperty declarations * Fix 2 for MaryEllen's comments * 8/8 EOD commit * 8/9 SOD * configModels * isaac-d-t * 8 13 localhost * remove package title and header * complete reducer * crazy translation error * scafolding bug fixes * Revert "8 13 localhost" This reverts commit 9de75d0. * readme merge * Revert "Revert "8 13 localhost"" This reverts commit 2b42e8c. * fix for mary ellen's cooments 1 * remove css from svg * removing warnings * packagesColumnDefs * copy right and spacing * work in progress * Display data in grid * reset app.config * fix for mary ellen's comments * Merge Master into Edge Feature Branch (#1073) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Add newPackage Flyout (#1070) * newPackage commit 1 * onChange * upload successful * add new package to grid * newPackage complete * alignment * remove color inside theme * combine * .new-package-header combine * error message * single delete * Delete package (#1076) * newPackage commit 1 * onChange * upload successful * add new package to grid * newPackage complete * alignment * remove color inside theme * combine * .new-package-header combine * error message * single delete * deletePackage commit 1 * deletePackage commit 2 * delete commit 3 * delete commit 4 * README.md * ME's review comments fix * Fix for Elvin's Comments * fix for stephen's comments * Merge Master into Edge feature branch (#1083) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * example * add packages * Deployments page scaffolding (#1088) * Merge Master into Edge Feature Branch to keep it up to date (#1091) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * Rename Package Flyouts to be consistent with rest of UI (#1087) * Rename Package Flyouts to be consistent with rest of UI * rename path * Add glimmer icon to newly added grid items (#1095) * Add glimmer icon to newly added grid items * Add new Deployment (#1096) * Add new Deployment * Fix for ME's review coments * DevicesByCondition * undefined * Fix for ME's 2nd comments * alphabetical order * Merge Master into Edge Feature Branch (#1100) * Merge Master into Feature branch for Edge * nits * Add glimmer icon for newly added deployments (#1101) * More context bar arrangement; also page titles (#1104) * More context bar arrangement; also page titles * format per vscode auto formatting * implement new ComponentArray and change existing code to use it (#1108) * Followup to remove more keys for ComponentArray usage (#1109) * Merge Master with Feature Branch (#1111) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * rearrange controls on context menus (#1093) * Add links to Time Series Insights from Dashboard and Device Details Page (#1085) Add a Hyperlink shared component Fetch the Time Series Explorer URL from Telemetry Add link to dashboard and device details * Adding curly brackets in json Payload (#1094) * Fix alignment of stats on dashbaord (quick fix) (#1097) * Move Add Condition button below the rule conditions (#1103) * Update section decriptions to be more actionable on Device Details (#1110) * Fix device insert reducer function so the id in the items list is a string (not an array) (#1114) * Adding Deployment Details Page (#1112) * Squash DeploymentDetails commits * initial review fixes * review comments fix part 2 * fix for Stephen's review comments * adding test page and minor fixes * ByQuery * fix deployments tests * Delete Modal for Packages and Deployments Page (#1115) * delete Packages and delete Deployments * remove deleteDeployment.container * remove componentArray from deploymentDetailsGrid * remove payload * onrowclicked and softselected for deviceDetails * remove comment * id = '' * Adding Deployment message details formatting and removing onRowClick (#1117) * Deployment message details formatting and removing onRowClick * fix for stephen's comments * minimize setState calls * refactoring componentWillReceiveProps * semicolon and single line * Replacing ids with Names and removing IOThubmanager's dependency on c… (#1120) * replacing ids with Names and removing IOThubmanager's dependency on config service * type * Adding In-porduct telemetry for Packages and Deployments (#1122) * Adding In-porduct telemetry for Packages and Deployments * remove unused model * Styling update (#1124) * Styling update * red * * new line * Merge master into Edge Feature branch (#1125) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * rearrange controls on context menus (#1093) * Add links to Time Series Insights from Dashboard and Device Details Page (#1085) Add a Hyperlink shared component Fetch the Time Series Explorer URL from Telemetry Add link to dashboard and device details * Adding curly brackets in json Payload (#1094) * Fix alignment of stats on dashbaord (quick fix) (#1097) * Move Add Condition button below the rule conditions (#1103) * Update section decriptions to be more actionable on Device Details (#1110) * fix shell.test.js (#1116) * unit Test fix * entities length > 0 * Fix for bugBash bugs (#1130) # Conflicts: # src/store/reducers/deploymentsReducer.js * keyboard accessibility fix (#1131) * Update User Voice Link (#1136) Update the user voice link to point to our new Solution Accelerators User Voice. * Add New Edge device (#1135) * Add New Edge device * indentation * Get Auth Token in an Async way to resolve dashboard Oops error when idle (#1147)
molly-moen
pushed a commit
that referenced
this pull request
Nov 9, 2018
* Add tags to embed snippets in docs (#1123) * Add tags to basic page * Add tags for doc embedding * npm audit fix (#1121) * Merge Edge Feature Branch into Master (#1127) * Add scaffolding for packages page (#1063) * pakages tab * Packages Folder * Reusable Header Components * package svg * fix for mary ellen's comments * Fix for Stephen's comments * README update 1 * oneProperty declarations * Fix 2 for MaryEllen's comments * 8/8 EOD commit * 8/9 SOD * configModels * isaac-d-t * 8 13 localhost * remove package title and header * complete reducer * crazy translation error * scafolding bug fixes * Revert "8 13 localhost" This reverts commit 9de75d0. * readme merge * fix for mary ellen's cooments 1 * remove css from svg * removing warnings * copy right and spacing * work in progress * Display content in packages grid (#1068) * pakages tab * Packages Folder * Reusable Header Components * package svg * fix for mary ellen's comments * Fix for Stephen's comments * README update 1 * oneProperty declarations * Fix 2 for MaryEllen's comments * 8/8 EOD commit * 8/9 SOD * configModels * isaac-d-t * 8 13 localhost * remove package title and header * complete reducer * crazy translation error * scafolding bug fixes * Revert "8 13 localhost" This reverts commit 9de75d0. * readme merge * Revert "Revert "8 13 localhost"" This reverts commit 2b42e8c. * fix for mary ellen's cooments 1 * remove css from svg * removing warnings * packagesColumnDefs * copy right and spacing * work in progress * Display data in grid * reset app.config * fix for mary ellen's comments * Merge Master into Edge Feature Branch (#1073) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Add newPackage Flyout (#1070) * newPackage commit 1 * onChange * upload successful * add new package to grid * newPackage complete * alignment * remove color inside theme * combine * .new-package-header combine * error message * single delete * Delete package (#1076) * newPackage commit 1 * onChange * upload successful * add new package to grid * newPackage complete * alignment * remove color inside theme * combine * .new-package-header combine * error message * single delete * deletePackage commit 1 * deletePackage commit 2 * delete commit 3 * delete commit 4 * README.md * ME's review comments fix * Fix for Elvin's Comments * fix for stephen's comments * Merge Master into Edge feature branch (#1083) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * example * add packages * Deployments page scaffolding (#1088) * Merge Master into Edge Feature Branch to keep it up to date (#1091) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * Rename Package Flyouts to be consistent with rest of UI (#1087) * Rename Package Flyouts to be consistent with rest of UI * rename path * Add glimmer icon to newly added grid items (#1095) * Add glimmer icon to newly added grid items * Add new Deployment (#1096) * Add new Deployment * Fix for ME's review coments * DevicesByCondition * undefined * Fix for ME's 2nd comments * alphabetical order * Merge Master into Edge Feature Branch (#1100) * Merge Master into Feature branch for Edge * nits * Add glimmer icon for newly added deployments (#1101) * More context bar arrangement; also page titles (#1104) * More context bar arrangement; also page titles * format per vscode auto formatting * implement new ComponentArray and change existing code to use it (#1108) * Followup to remove more keys for ComponentArray usage (#1109) * Merge Master with Feature Branch (#1111) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * rearrange controls on context menus (#1093) * Add links to Time Series Insights from Dashboard and Device Details Page (#1085) Add a Hyperlink shared component Fetch the Time Series Explorer URL from Telemetry Add link to dashboard and device details * Adding curly brackets in json Payload (#1094) * Fix alignment of stats on dashbaord (quick fix) (#1097) * Move Add Condition button below the rule conditions (#1103) * Update section decriptions to be more actionable on Device Details (#1110) * Fix device insert reducer function so the id in the items list is a string (not an array) (#1114) * Adding Deployment Details Page (#1112) * Squash DeploymentDetails commits * initial review fixes * review comments fix part 2 * fix for Stephen's review comments * adding test page and minor fixes * ByQuery * fix deployments tests * Delete Modal for Packages and Deployments Page (#1115) * delete Packages and delete Deployments * remove deleteDeployment.container * remove componentArray from deploymentDetailsGrid * remove payload * onrowclicked and softselected for deviceDetails * remove comment * id = '' * Adding Deployment message details formatting and removing onRowClick (#1117) * Deployment message details formatting and removing onRowClick * fix for stephen's comments * minimize setState calls * refactoring componentWillReceiveProps * semicolon and single line * Replacing ids with Names and removing IOThubmanager's dependency on c… (#1120) * replacing ids with Names and removing IOThubmanager's dependency on config service * type * Adding In-porduct telemetry for Packages and Deployments (#1122) * Adding In-porduct telemetry for Packages and Deployments * remove unused model * Styling update (#1124) * Styling update * red * * new line * Merge master into Edge Feature branch (#1125) * Dev Walkthru: add a new Panel to the Dashboard (#1062) * Dev Walkthru: add a new Panel to the Dashboard * small tweaks, review feedback * fix bad code end marker * Diagnostics bugFix (#1065) * flatMap * Dummy comment to retrigger build * Add Rule Diagnostics (#1064) Add diagnostics logging for rule create/update events. Added the following metrics: Rule_NewClick Rule_EditClick Rule_DeviceGroupClick Rule_CalculationClick Rule_FieldClick Rule_OperatorClick Rule_AddConditionClick Rule_SeverityLevelClick Rule_StatusToggle Rule_ApplyClick Rule_CancelClick Rule_TopXCloseClick Also includes new "sessionid" sections of diagnostics call, which logs the time in ms since Jan 1, 1970 when the page was loaded (amplitude expects session id in this format). This fields will be added by diagnostics to enable logging of session id to amplitude--until those changes go in it will be ignored by the backend. * Delete .travis.yml (#1066) * Delete .travis.yml * Update README.md * Add diagnostics for new device funnel (#1075) * Add device metrics Add metrics for new device flyout * Add device created metric Add metric on device create so we can log device id for physical devices * Fix rule apply event Rule apply click event was only emitted for new rules. Move call so it is emitted if a rule is added or edited. * Address comments and align metric names Address comments. Update metric names to be in same format as rule metrics * fix insertion when entities are null for devices and rules (#1078) * Refactor to make walkthrough code less intrusive (#1069) * refactor to make walkthrough code less intrusive * refactor after meeting with team * update MD files, move httpClient * review feedback * fix nit * update breadcrumbs to use isDef instead of checking undefined * Treat text and number correctly in device jobs (#1082) * treat text and number correctly in device jobs * fix formatting nit * Rule updates need to send ETag (#1084) UI needs to send the ETag when updating rules. * Rule enable/disable needs to update ETag in redux store (#1086) * Small updates for the add page walkthrough (#1089) * Making cloudToDeviceMethod to empty an string (#1090) * rearrange controls on context menus (#1093) * Add links to Time Series Insights from Dashboard and Device Details Page (#1085) Add a Hyperlink shared component Fetch the Time Series Explorer URL from Telemetry Add link to dashboard and device details * Adding curly brackets in json Payload (#1094) * Fix alignment of stats on dashbaord (quick fix) (#1097) * Move Add Condition button below the rule conditions (#1103) * Update section decriptions to be more actionable on Device Details (#1110) * fix shell.test.js (#1116) * unit Test fix * entities length > 0 * Fix for bugBash bugs (#1130) # Conflicts: # src/store/reducers/deploymentsReducer.js * keyboard accessibility fix (#1131) * Update User Voice Link (#1136) Update the user voice link to point to our new Solution Accelerators User Voice. * Add New Edge device (#1135) * Add New Edge device * indentation * Get Auth Token in an Async way to resolve dashboard Oops error when idle (#1147) * New way to handle SVGs (#1157) * Revert "Update actions branch with master for latest Edge changes (#1158)" This reverts commit 4e6714c.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change?
Description, Context, Motivation
Fix for issue: #1106
The problem was actually caused (not by glimmer), but by some changes in the insert reducer to better handle empty lists. The devices reducer is set up to handle everything in bulk... so the payloads are arrays (not single objects). So the insert reducer needed to handle them as arrays.
Checklist:
This change is